KAFKA-2428#282
Closed
MayureshGharat wants to merge 2 commits into
Closed
Conversation
Member
There was a problem hiding this comment.
Can you remove {} since there is only one line after if?
Otherwise LGTM
added 2 commits
October 7, 2015 10:37
7a9bd41 to
8c7e285
Compare
Member
|
LGTM |
efeg
added a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
* Bump up kafka and kafka-clients dependency to 2.0.0 * Remove dependency on li-apache-kafka-clients * Rebase code to work with kafka 2.0.0.
stanislavkozlovski
pushed a commit
to stanislavkozlovski/kafka
that referenced
this pull request
Mar 20, 2020
Without a license RAT complains. Now `gradlew rat` passes. Reviewers: Ismael Juma <ismael@juma.me.uk>
jsancio
pushed a commit
to jsancio/kafka
that referenced
this pull request
May 6, 2020
Without a license RAT complains. Now `gradlew rat` passes. Reviewers: Ismael Juma <ismael@juma.me.uk> (cherry picked from commit d3b2130)
gardnervickers
pushed a commit
to gardnervickers/kafka-1
that referenced
this pull request
Feb 4, 2021
Without a license RAT complains. Now `gradlew rat` passes. Reviewers: Ismael Juma <ismael@juma.me.uk> (cherry picked from commit d3b2130)
omkreddy
pushed a commit
to omkreddy/kafka
that referenced
this pull request
Feb 15, 2021
Without a license RAT complains. Now `gradlew rat` passes. Reviewers: Ismael Juma <ismael@juma.me.uk> (cherry picked from commit d3b2130)
omkreddy
pushed a commit
to omkreddy/kafka
that referenced
this pull request
Feb 15, 2021
Without a license RAT complains. Now `gradlew rat` passes. Reviewers: Ismael Juma <ismael@juma.me.uk> (cherry picked from commit d3b2130)
omkreddy
pushed a commit
to omkreddy/kafka
that referenced
this pull request
Feb 15, 2021
Without a license RAT complains. Now `gradlew rat` passes. Reviewers: Ismael Juma <ismael@juma.me.uk> (cherry picked from commit d3b2130)
omkreddy
pushed a commit
to omkreddy/kafka
that referenced
this pull request
Feb 15, 2021
Without a license RAT complains. Now `gradlew rat` passes. Reviewers: Ismael Juma <ismael@juma.me.uk> (cherry picked from commit d3b2130)
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 4, 2022
…che#131) (apache#282) [LI-HOTFIX] Add log brokerid for admin client listTopics failure (apache#131) TICKET = N/A LI_DESCRIPTION = VENG-7361 In VENG-7361, sometimes KafkaAdminClient#listTopics will time out. This patch adds logs to help show the broker that served the listTopic request, which can help us understand the timeout. EXIT_CRITERIA = N/A Co-authored-by: Alex Wang <alewang@linkedin.com>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
…che#131) (apache#282) [LI-HOTFIX] Add log brokerid for admin client listTopics failure (apache#131) TICKET = N/A LI_DESCRIPTION = VENG-7361 In VENG-7361, sometimes KafkaAdminClient#listTopics will time out. This patch adds logs to help show the broker that served the listTopic request, which can help us understand the timeout. EXIT_CRITERIA = N/A Co-authored-by: Alex Wang <alewang@linkedin.com>
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
…che#131) (apache#282) [LI-HOTFIX] Add log brokerid for admin client listTopics failure (apache#131) TICKET = N/A LI_DESCRIPTION = VENG-7361 In VENG-7361, sometimes KafkaAdminClient#listTopics will time out. This patch adds logs to help show the broker that served the listTopic request, which can help us understand the timeout. EXIT_CRITERIA = N/A Co-authored-by: Alex Wang <alewang@linkedin.com>
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
Measure how many batches are being committed.
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
Measure how many batches are being committed.
traceyyoshima
added a commit
to traceyyoshima/kafka
that referenced
this pull request
May 22, 2026
Single bulk apply of the Language Engine's IntelliJ-style format profile across the kafka source tree. Pairs with the IntelliJ-real control branch `intellij-formatting` for side-by-side comparison. Engine state at apply time includes the following format fixes landed against the language-engine repo: Pre-PR #11: - PR apache#275 multi-line // comment indent group - PR apache#276 BLANK_LINES_AROUND_CLASS + sibling no-op repair - PR apache#277 string-concat chain anchor preservation - PR apache#279 forward style through apply routes - PR apache#281 Result-tab line-number alignment - PR apache#282 spaces after return / throw / yield / instanceof - PR apache#283 chain-dot postfix preservation - PR apache#284 BlankLines sibling minimum.* conversion - PR apache#285 chain-dot single-anchor (N=1) preservation - PR apache#286 string-concat chain partial-cascade fix - PR apache#287 method-decl param re-align for misaligned source - PR apache#288 annotation-in-array-init indent Post-original-PR #11 (new in this re-apply): - PR apache#289 partial-cascade post-rewrite-anchor (4 shape fixes: chain-dot postfix follow-on, MI/NewClass close-paren cascade, ternary continuation, lambda body continuation) Stats: 3101 files written, 0 failures, 2678 already-idempotent files skipped (no_change). Corpus byte delta vs trunk: -510 bytes (106275 insertions / 106785 deletions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sanity test in kafkaConsumer for the timeouts. This is a followup ticket for Kafka-2120.