Skip to content

KAFKA-2620: Introduce Scalariform#284

Closed
granthenke wants to merge 1 commit into
apache:trunkfrom
granthenke:scalariform
Closed

KAFKA-2620: Introduce Scalariform#284
granthenke wants to merge 1 commit into
apache:trunkfrom
granthenke:scalariform

Conversation

@granthenke

Copy link
Copy Markdown
Member

This is a WIP. There will likely need to be discussion around a rule set we want to use and if we actually want to include this in the build. This could also be used as a one time rebase.

This commit does not include the actual formatting changes. To see what effect the patch has run
gradle formatScala

@guozhangwang

Copy link
Copy Markdown
Contributor

@granthenke Would you like to continue working on this JIRA and PR?

@asfbot

asfbot commented Dec 21, 2016

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.11/333/
Test FAILed (JDK 8 and Scala 2.11).

@asfbot

asfbot commented Dec 21, 2016

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/332/
Test FAILed (JDK 8 and Scala 2.12).

@asfbot

asfbot commented Dec 21, 2016

Copy link
Copy Markdown

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-jdk7-scala2.10/331/
Test FAILed (JDK 7 and Scala 2.10).

@ijuma

ijuma commented Dec 23, 2017

Copy link
Copy Markdown
Member

I think we may want to use scalafmt instead as it supports a maxColumn setting:

http://scalameta.org/scalafmt/#FAQ/Troubleshooting

@ijuma

ijuma commented Dec 23, 2017

Copy link
Copy Markdown
Member

Closing as this has been inactive for a while.

@ijuma ijuma closed this Dec 23, 2017
stanislavkozlovski pushed a commit to stanislavkozlovski/kafka that referenced this pull request Mar 20, 2020
Fixes groovy.lang.MissingPropertyException: No such property: downstreamBuildFailureOutput for class: WorkflowScript

This happened because we run things slightly differently on master compared to a PR.
wyuka pushed a commit to wyuka/kafka that referenced this pull request Mar 4, 2022
…pache#203) (apache#284)

[LI-HOTFIX] Add end-to-end message latency sensor for kafka producer (apache#203)
Add end-to-end message latency sensor for kafka producer

LIKAFKA-37898

(cherry picked from commit cfbfa5a)
Fixing build errors

Co-authored-by: Zhe Song <zhsong@linkedin.com>
wyuka pushed a commit to wyuka/kafka that referenced this pull request Mar 28, 2022
…pache#284)

[LI-HOTFIX] Add end-to-end message latency sensor for kafka producer (apache#203)
Add end-to-end message latency sensor for kafka producer

LIKAFKA-37898

(cherry picked from commit cfbfa5a)
Fixing build errors

Co-authored-by: Zhe Song <zhsong@linkedin.com>
wyuka pushed a commit to wyuka/kafka that referenced this pull request Jun 16, 2022
…pache#284)

[LI-HOTFIX] Add end-to-end message latency sensor for kafka producer (apache#203)
Add end-to-end message latency sensor for kafka producer

LIKAFKA-37898

(cherry picked from commit cfbfa5a)
Fixing build errors

Co-authored-by: Zhe Song <zhsong@linkedin.com>
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
Allow to virtually disable merger/cleaner by setting a large interval.
jeqo added a commit to aiven/kafka that referenced this pull request Jan 16, 2026
Allow to virtually disable merger/cleaner by setting a large interval.
traceyyoshima added a commit to traceyyoshima/kafka that referenced this pull request May 22, 2026
Single bulk apply of the Language Engine's IntelliJ-style format
profile across the kafka source tree. Pairs with the IntelliJ-real
control branch `intellij-formatting` for side-by-side comparison.

Engine state at apply time includes the following format fixes
landed against the language-engine repo:

  Pre-PR #11:
  - PR apache#275 multi-line // comment indent group
  - PR apache#276 BLANK_LINES_AROUND_CLASS + sibling no-op repair
  - PR apache#277 string-concat chain anchor preservation
  - PR apache#279 forward style through apply routes
  - PR apache#281 Result-tab line-number alignment
  - PR apache#282 spaces after return / throw / yield / instanceof
  - PR apache#283 chain-dot postfix preservation
  - PR apache#284 BlankLines sibling minimum.* conversion
  - PR apache#285 chain-dot single-anchor (N=1) preservation
  - PR apache#286 string-concat chain partial-cascade fix
  - PR apache#287 method-decl param re-align for misaligned source
  - PR apache#288 annotation-in-array-init indent

  Post-original-PR #11 (new in this re-apply):
  - PR apache#289 partial-cascade post-rewrite-anchor (4 shape fixes:
    chain-dot postfix follow-on, MI/NewClass close-paren cascade,
    ternary continuation, lambda body continuation)

Stats: 3101 files written, 0 failures, 2678 already-idempotent
files skipped (no_change). Corpus byte delta vs trunk: -510 bytes
(106275 insertions / 106785 deletions).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants