Apply Language Engine formatter under style=intellij#11
Closed
traceyyoshima wants to merge 1 commit into
Closed
Conversation
Single bulk apply of the Language Engine's IntelliJ-style format profile across the kafka source tree. Pairs with the IntelliJ-real control branch `intellij-formatting` for side-by-side comparison of LE's IntelliJ output against IntelliJ's own reformat. Stats: 3101 files written, 0 failures, 2678 already-idempotent files skipped (no_change).
traceyyoshima
added a commit
that referenced
this pull request
May 22, 2026
Single bulk apply of the Language Engine's IntelliJ-style format profile across the kafka source tree. Pairs with the IntelliJ-real control branch `intellij-formatting` for side-by-side comparison. Engine state at apply time includes the following format fixes landed against the language-engine repo: Pre-PR #11: - PR apache#275 multi-line // comment indent group - PR apache#276 BLANK_LINES_AROUND_CLASS + sibling no-op repair - PR apache#277 string-concat chain anchor preservation - PR apache#279 forward style through apply routes - PR apache#281 Result-tab line-number alignment - PR apache#282 spaces after return / throw / yield / instanceof - PR apache#283 chain-dot postfix preservation - PR apache#284 BlankLines sibling minimum.* conversion - PR apache#285 chain-dot single-anchor (N=1) preservation - PR apache#286 string-concat chain partial-cascade fix - PR apache#287 method-decl param re-align for misaligned source - PR apache#288 annotation-in-array-init indent Post-original-PR #11 (new in this re-apply): - PR apache#289 partial-cascade post-rewrite-anchor (4 shape fixes: chain-dot postfix follow-on, MI/NewClass close-paren cascade, ternary continuation, lambda body continuation) Stats: 3101 files written, 0 failures, 2678 already-idempotent files skipped (no_change). Corpus byte delta vs trunk: -510 bytes (106275 insertions / 106785 deletions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single bulk apply of the Language Engine's IntelliJ-style format profile across the kafka source tree. Pairs with the IntelliJ-real control draft (
intellij-formatting) so each PR shows its formatter's diff vstrunk@164256f127and the two outputs can be eyeballed side-by-side.What was applied
Format profile:
IntelliJ.defaults().toStyle()— the Language Engine's projection of IntelliJ's Java Code Style → Default settings. Wired via:Style.Strictness = EXPLICIT(forces normalization of source outliers rather than the heuristic-mode preserve-outliers default).//comment indent groupTooManyConnectionsExceptionthreshold (max.connections.per.ip) is reached apache/kafka#288 annotation-in-array-init indentApply stats
Net byte delta vs trunk: −470 bytes (99,702 insertions / 100,172 deletions).
Comparison with the IntelliJ control
Control branch (
intellij-formatting): 1 commit ontrunk@164256f12with IntelliJ's reformat applied. Reports ~4,086 files changed, +177,944 / −180,083 bytes.This LE-format PR:
Direct file-pair comparison is best done by checking individual files in both PRs side-by-side; the difference set is where LE diverges from IntelliJ's reformat.
Draft
Filed as draft — not a candidate for merge, this is an output snapshot for review.