KAFKA-2476: Add Decimal, Date, and Timestamp logical types.#281
Closed
ewencp wants to merge 3 commits into
Closed
Conversation
To support Decimal, this also adds support for schema parameters, which is an extra set of String key value pairs which provide extra information about the schema. For Decimal, this is used to encode the scale parameter, which is part of the schema instead of being passed with every value.
Contributor
There was a problem hiding this comment.
Could we have additional CopycatSchema constructors that put default field values as null?
Contributor
Author
There was a problem hiding this comment.
We definitely could. I expected that people would almost always use SchemaBuilder to construct Schema objects so I wasn't that worried about making a variety of constructors available. Aside from tests, we only directly construct these objects in a one or two locations.
Contributor
|
LGTM except minor comments. Could you rebase? |
… don't overwrite a method parameter's value in JsonConverter.
Contributor
Author
|
@guozhangwang merged and addressed most of your comments. The one I wasn't sure about was the one about invalidating parameter values as non-strings. Can you clarify what you were looking for there? |
efeg
pushed a commit
to efeg/kafka
that referenced
this pull request
Jan 29, 2020
omkreddy
pushed a commit
to omkreddy/kafka
that referenced
this pull request
Feb 15, 2021
Reviewers: Ismael Juma <ismael@juma.me.uk>
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
…he#281) * refactor(inkless:docker): consolidate docker composes Move all docker setup under docker/examples/docker-compose-files to reuse the demo for all setups--while keeping the commands/docs the same * docs(inkless:docker): show how to rebuild image
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
…he#281) * refactor(inkless:docker): consolidate docker composes Move all docker setup under docker/examples/docker-compose-files to reuse the demo for all setups--while keeping the commands/docs the same * docs(inkless:docker): show how to rebuild image
traceyyoshima
added a commit
to traceyyoshima/kafka
that referenced
this pull request
May 22, 2026
Single bulk apply of the Language Engine's IntelliJ-style format profile across the kafka source tree. Pairs with the IntelliJ-real control branch `intellij-formatting` for side-by-side comparison. Engine state at apply time includes the following format fixes landed against the language-engine repo: Pre-PR #11: - PR apache#275 multi-line // comment indent group - PR apache#276 BLANK_LINES_AROUND_CLASS + sibling no-op repair - PR apache#277 string-concat chain anchor preservation - PR apache#279 forward style through apply routes - PR apache#281 Result-tab line-number alignment - PR apache#282 spaces after return / throw / yield / instanceof - PR apache#283 chain-dot postfix preservation - PR apache#284 BlankLines sibling minimum.* conversion - PR apache#285 chain-dot single-anchor (N=1) preservation - PR apache#286 string-concat chain partial-cascade fix - PR apache#287 method-decl param re-align for misaligned source - PR apache#288 annotation-in-array-init indent Post-original-PR #11 (new in this re-apply): - PR apache#289 partial-cascade post-rewrite-anchor (4 shape fixes: chain-dot postfix follow-on, MI/NewClass close-paren cascade, ternary continuation, lambda body continuation) Stats: 3101 files written, 0 failures, 2678 already-idempotent files skipped (no_change). Corpus byte delta vs trunk: -510 bytes (106275 insertions / 106785 deletions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support Decimal, this also adds support for schema parameters, which is an
extra set of String key value pairs which provide extra information about the
schema. For Decimal, this is used to encode the scale parameter, which is part
of the schema instead of being passed with every value.