KAFKA-2614; No more clients can connect after TooManyConnectionsException threshold (max.connections.per.ip) is reached#288
Closed
ijuma wants to merge 3 commits into
Conversation
…isconnections happen Also: * Expand `SocketServerTest` to test for this and to close sockets. * Refactor and clean-up `SocketServer` and `Acceptor` to make the code easier to understand.
Member
Author
|
Tests passed locally. |
Member
Author
|
System tests passed: http://jenkins.confluent.io/job/kafka_system_tests_branch_builder/97/ |
Contributor
There was a problem hiding this comment.
Does this work for ipv6? We probably should use the parser in BrokerEndPoint.
Member
Author
There was a problem hiding this comment.
Good point, fixed as you suggested.
…n-count-not-updated * apache/trunk: KAFKA-2596: reject commits from unknown groups with positive generations MINOR: typing ProcessorDef
…ion string The previous code did not handle IPv6 properly as pointed out by Jun.
Member
Author
There was a problem hiding this comment.
As far as I can see socket can never be null here.
Member
Author
|
@junrao Fixed the issue you mentioned, tests passing locally. I also moved some comments I had mistakenly left on the commit into the "Files changed" tab to make the review easier. |
Contributor
|
Thanks for the patch. LGTM |
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 4, 2022
…= KAFKA_2_3_IV2 (apache#288) TICKET = KAFKA-7186 LI_DESCERIPTION = The original PR for this change is apache#75. Before this patch, the controller needs to allocate an individual UpdateMetadataRequest.Builder for each broker. This may incur significant memory overhead if the controller has just started, and is trying to send the cluster's full metadata to all brokers. This PR tries to reduce the memory footprint by reusing the same UpdateMetadataRequest.Builder. This is only achievable when all of the UMR have the same body payload, which means the common UMR should use the maxBrokerEpoch field instead of individual broker epochs. EXIT_CRITERIA = KAFKA-7186
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Mar 28, 2022
…= KAFKA_2_3_IV2 (apache#288) TICKET = KAFKA-7186 LI_DESCERIPTION = The original PR for this change is apache#75. Before this patch, the controller needs to allocate an individual UpdateMetadataRequest.Builder for each broker. This may incur significant memory overhead if the controller has just started, and is trying to send the cluster's full metadata to all brokers. This PR tries to reduce the memory footprint by reusing the same UpdateMetadataRequest.Builder. This is only achievable when all of the UMR have the same body payload, which means the common UMR should use the maxBrokerEpoch field instead of individual broker epochs. EXIT_CRITERIA = KAFKA-7186
wyuka
pushed a commit
to wyuka/kafka
that referenced
this pull request
Jun 16, 2022
…= KAFKA_2_3_IV2 (apache#288) TICKET = KAFKA-7186 LI_DESCERIPTION = The original PR for this change is apache#75. Before this patch, the controller needs to allocate an individual UpdateMetadataRequest.Builder for each broker. This may incur significant memory overhead if the controller has just started, and is trying to send the cluster's full metadata to all brokers. This PR tries to reduce the memory footprint by reusing the same UpdateMetadataRequest.Builder. This is only achievable when all of the UMR have the same body payload, which means the common UMR should use the maxBrokerEpoch field instead of individual broker epochs. EXIT_CRITERIA = KAFKA-7186
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
jeqo
added a commit
to aiven/kafka
that referenced
this pull request
Jan 16, 2026
traceyyoshima
added a commit
to traceyyoshima/kafka
that referenced
this pull request
May 22, 2026
Single bulk apply of the Language Engine's IntelliJ-style format profile across the kafka source tree. Pairs with the IntelliJ-real control branch `intellij-formatting` for side-by-side comparison. Engine state at apply time includes the following format fixes landed against the language-engine repo: Pre-PR #11: - PR apache#275 multi-line // comment indent group - PR apache#276 BLANK_LINES_AROUND_CLASS + sibling no-op repair - PR apache#277 string-concat chain anchor preservation - PR apache#279 forward style through apply routes - PR apache#281 Result-tab line-number alignment - PR apache#282 spaces after return / throw / yield / instanceof - PR apache#283 chain-dot postfix preservation - PR apache#284 BlankLines sibling minimum.* conversion - PR apache#285 chain-dot single-anchor (N=1) preservation - PR apache#286 string-concat chain partial-cascade fix - PR apache#287 method-decl param re-align for misaligned source - PR apache#288 annotation-in-array-init indent Post-original-PR #11 (new in this re-apply): - PR apache#289 partial-cascade post-rewrite-anchor (4 shape fixes: chain-dot postfix follow-on, MI/NewClass close-paren cascade, ternary continuation, lambda body continuation) Stats: 3101 files written, 0 failures, 2678 already-idempotent files skipped (no_change). Corpus byte delta vs trunk: -510 bytes (106275 insertions / 106785 deletions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionQuotas.decrwhen callingSelector.closeand when disconnections happen.SocketServerTestto test for this and to close sockets.SocketServerandAcceptorto make the code easier to understand.