Skip to content

MINOR: Make indenting in checkstyle.xml and import-control.xml consistent#253

Closed
ijuma wants to merge 1 commit into
apache:trunkfrom
ijuma:fix-xml-indents
Closed

MINOR: Make indenting in checkstyle.xml and import-control.xml consistent#253
ijuma wants to merge 1 commit into
apache:trunkfrom
ijuma:fix-xml-indents

Conversation

@ijuma

@ijuma ijuma commented Sep 28, 2015

Copy link
Copy Markdown
Member

They now both use 2 spaces for indents, which is what checkstyle.xml was
already doing. import.xml had a mixture of tabs and 4 spaces previously.

They now both use 2 spaces for indents, which is what `checkstyle.xml` was
already doing. `import.xml` had a mixture of tabs and 4 spaces previously.
@asfbot

asfbot commented Sep 28, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #576 FAILURE
Looks like there's a problem with this pull request

@ijuma

ijuma commented Sep 28, 2015

Copy link
Copy Markdown
Member Author

Failure (SimpleAclAuthorizerTest) not related to this change

@gwenshap

Copy link
Copy Markdown
Contributor

LGTM. Thanks for noticing and fixing.

@asfgit asfgit closed this in 4e7db39 Sep 28, 2015
@ijuma ijuma deleted the fix-xml-indents branch March 1, 2016 22:49
jsancio pushed a commit to jsancio/kafka that referenced this pull request Aug 6, 2019
wyuka pushed a commit to wyuka/kafka that referenced this pull request Feb 4, 2022
TICKET = LIKAFKA-41601
LI_DESCRIPTION = 
Current RequestEnqueueTime metric for controller requests does not provide a clear view when request is stuck at remote. That metric only reports value after the response is received. If the response is never received, the metric will not report any value. This PR adds a new metric that purely based on request enqueue time and the current time, which can always report the age of the latest request. 
EXIT_CRITERIA =
wyuka pushed a commit to wyuka/kafka that referenced this pull request Mar 16, 2022
This also squashes a fix commit
- 2ffa2f9 [LI-HOTFIX]  Add tag for brokerId on metric maxRequestAge (apache#276)

TICKET = LIKAFKA-41601
LI_DESCRIPTION =
Current RequestEnqueueTime metric for controller requests does not provide a clear view when request is stuck at remote. That metric only reports value after the response is received. If the response is never received, the metric will not report any value. This PR adds a new metric that purely based on request enqueue time and the current time, which can always report the age of the latest request.
EXIT_CRITERIA =

Co-authored-by: Hao Geng <hgeng@hgeng-mn1.linkedin.biz>
wyuka pushed a commit to wyuka/kafka that referenced this pull request Mar 28, 2022
This also squashes a fix commit
- 2ffa2f9 [LI-HOTFIX]  Add tag for brokerId on metric maxRequestAge (apache#276)

TICKET = LIKAFKA-41601
LI_DESCRIPTION =
Current RequestEnqueueTime metric for controller requests does not provide a clear view when request is stuck at remote. That metric only reports value after the response is received. If the response is never received, the metric will not report any value. This PR adds a new metric that purely based on request enqueue time and the current time, which can always report the age of the latest request.
EXIT_CRITERIA =

Co-authored-by: Hao Geng <hgeng@hgeng-mn1.linkedin.biz>
wyuka pushed a commit to wyuka/kafka that referenced this pull request Jun 16, 2022
This also squashes a fix commit
- 2ffa2f9 [LI-HOTFIX]  Add tag for brokerId on metric maxRequestAge (apache#276)

TICKET = LIKAFKA-41601
LI_DESCRIPTION =
Current RequestEnqueueTime metric for controller requests does not provide a clear view when request is stuck at remote. That metric only reports value after the response is received. If the response is never received, the metric will not report any value. This PR adds a new metric that purely based on request enqueue time and the current time, which can always report the age of the latest request.
EXIT_CRITERIA =

Co-authored-by: Hao Geng <hgeng@hgeng-mn1.linkedin.biz>
udaynpusa pushed a commit to mapr/kafka that referenced this pull request Jan 30, 2024
…(adapt tests) (apache#253)

Co-authored-by: Yaroslav Chernysh <yarocher01@gmail.com>
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
* Document that Inkless is not long-term fork

* fixup! Document that Inkless is not long-term fork
jeqo pushed a commit to aiven/kafka that referenced this pull request Jan 16, 2026
* Document that Inkless is not long-term fork

* fixup! Document that Inkless is not long-term fork
traceyyoshima added a commit to traceyyoshima/kafka that referenced this pull request May 17, 2026
…pache#257)

Refreshed snapshot from the kafka format sweep review. Five
language-engine PRs landed in this session:

- PR apache#253 — Annotation paren anchor for continuation slots
- PR apache#254 — StructuralBody2x catalog class for inline lambda bodies
- PR apache#255 — Lambda body as continuation enclosing scope
- PR apache#256 — Inline-lambda body close brace catalog (+0 / +projectDelta)
- PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot

Sweep stats (post-apache#257):
  files scanned : 5,834
  files changed : 1,027 (17.6%)   [initial PR #6: 1,038]
  byte delta    : -10,877          [initial PR #6: -6,661]
  reformat time : 7.2s total, 1.23 ms/file

The larger byte delta vs. the initial sweep reflects PR apache#257
fixing the AsyncKafkaConsumerTest-style "body at col 48" pattern
across multiple files — body statements no longer indent to the
inflated close-paren-line column, so each affected line shrinks
by 30+ characters.

Remaining patterns deferred to subsequent PRs:
  - Chain-dot over-application on Class.STATIC_FIELD / new X()
    (AdminClientConfig L273/L282, WriteTxnMarkersRequest L135,
    TxnOffsetCommitRequest L156/L159)
  - Partial-shift inconsistencies (StreamsResetter, ClientUtilsTest,
    RequestResponseTest, LeaveGroupRequest*, AlterReplicaLogDirs)
  - Trailing-whitespace cleanups on blank lines (incidental noise)
traceyyoshima added a commit to traceyyoshima/kafka that referenced this pull request May 17, 2026
…pache#258)

Refreshed snapshot. Six language-engine PRs landed this session:

- PR apache#253 — Annotation paren anchor for continuation slots
- PR apache#254 — StructuralBody2x catalog class for inline lambda bodies
- PR apache#255 — Lambda body as continuation enclosing scope
- PR apache#256 — Inline-lambda body close brace catalog (+0 / +projectDelta)
- PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot
- PR apache#258 — alignmentTargets restricted to OWNER's prefix slot

Sweep stats (post-apache#258):
  files scanned : 5,834
  files changed : 1,000 (17.1%)   [initial PR #6: 1,038]
  byte delta    : -10,630          [initial PR #6: -6,661]
  reformat time : 7.1s total, 1.22 ms/file

Remaining patterns (deferred):
  - Outer chain-dot receiver-anchor variations (TxnOffsetCommitRequest
    L156/L159, RequestResponseTest L3373+, etc.) — separate path from
    PR apache#258's inner-arg fix
  - Small continuation normalizations of non-standard source
    (StreamsResetter, ClientUtilsTest, LeaveGroupRequestTest)
  - Trailing-whitespace cleanups on blank lines (incidental noise)
traceyyoshima added a commit to traceyyoshima/kafka that referenced this pull request May 17, 2026
…pache#259)

Refreshed snapshot. Seven language-engine PRs landed this session:

- PR apache#253 — Annotation paren anchor for continuation slots
- PR apache#254 — StructuralBody2x catalog class for inline lambda bodies
- PR apache#255 — Lambda body as continuation enclosing scope
- PR apache#256 — Inline-lambda body close brace catalog
- PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot
- PR apache#258 — alignmentTargets restricted to OWNER's prefix slot
- PR apache#259 — Chain wrap preservation when siblings agree on column

Sweep stats (post-apache#259):
  files scanned : 5,834
  files changed : 990 (17.0%)     [initial PR #6: 1,038]
  byte delta    : -10,685          [initial PR #6: -6,661]
  reformat time : ~7s total

Most called-out files from the user's original review now fully
closed:
  - ShareConsumerTest (body + close brace)
  - ProducerIdExpirationTest
  - DeleteAclsResponse
  - CustomQuotaCallbackTest
  - AsyncKafkaConsumerTest (body indent regression)
  - AdminClientConfig L273/L282
  - WriteTxnMarkersRequest L135
  - TxnOffsetCommitRequest L156-159
  - RequestResponseTest chain shifts
  - AlterReplicaLogDirsRequestTest (cascade-closed)

Remaining residuals (~5 files, small):
  - StreamsResetter L580 (single `||` continuation normalisation)
  - ClientUtilsTest L79/L143 (continuation normalisation)
  - LeaveGroupRequestTest L55 (continuation shift)
  - LeaveGroupResponseTest (trailing-ws on blank lines)
  - ReassignPartitionsUnitTest (single line)

These are mostly the formatter normalising slightly non-standard
source — not really bugs.
traceyyoshima added a commit to traceyyoshima/kafka that referenced this pull request May 17, 2026
…pache#260)

Refreshed snapshot. Eight language-engine PRs landed this session:

- PR apache#253 — Annotation paren anchor for continuation slots
- PR apache#254 — StructuralBody2x catalog class for inline lambda bodies
- PR apache#255 — Lambda body as continuation enclosing scope
- PR apache#256 — Inline-lambda body close brace catalog
- PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot
- PR apache#258 — alignmentTargets restricted to OWNER's prefix slot
- PR apache#259 — Chain wrap preservation when siblings agree on column
- PR apache#260 — Binary OPERATOR_PREFIX consults outermost binary's anchor

Sweep stats (post-apache#260):
  files scanned : 5,834
  files changed : 989 (17.0%)     [initial PR #6: 1,038]
  byte delta    : -10,663
  reformat time : ~7s total

Almost all called-out files from the user's original review now
fully closed. Remaining residuals (<5 files) are correct
normalisations of slightly non-standard source or trailing
whitespace inside comment content (intentionally out of scope for
this engine version per user design choice).
traceyyoshima added a commit to traceyyoshima/kafka that referenced this pull request May 17, 2026
…pache#261)

Refreshed snapshot. Nine language-engine PRs landed this session:

- PR apache#253 — Annotation paren anchor for continuation slots
- PR apache#254 — StructuralBody2x catalog class for inline lambda bodies
- PR apache#255 — Lambda body as continuation enclosing scope
- PR apache#256 — Inline-lambda body close brace catalog
- PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot
- PR apache#258 — alignmentTargets restricted to OWNER's prefix slot
- PR apache#259 — Chain wrap preservation when siblings agree on column
- PR apache#260 — Binary OPERATOR_PREFIX consults outermost binary's anchor
- PR apache#261 — Nested continuation slots use innermost enclosing scope

Sweep stats (post-apache#261):
  files scanned : 5,834
  files changed : 986 (16.9%)     [initial PR #6: 1,038]
  byte delta    : -11,137          [initial PR #6: -6,661]
  reformat time : ~7s total

PR #7 review comments status:
  - Comments 1+2 closed (PR apache#261)
  - Comments 3 + 4/5 deferred (workbench-first investigation; diagnosis
    captured in language-engine memory project_pr7_deferred_comments_2026_05_17.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants