Skip to content

KAFKA-2597: Add to .gitignore the Eclipse IDE directories#259

Closed
rhauch wants to merge 1 commit into
apache:trunkfrom
rhauch:kafka-2597
Closed

KAFKA-2597: Add to .gitignore the Eclipse IDE directories#259
rhauch wants to merge 1 commit into
apache:trunkfrom
rhauch:kafka-2597

Conversation

@rhauch

@rhauch rhauch commented Sep 29, 2015

Copy link
Copy Markdown
Contributor

The .metadata and .recommenders keep IDE workspace state and should not be committed.

@asfbot

asfbot commented Sep 29, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #594 SUCCESS
This pull request looks good

@guozhangwang

Copy link
Copy Markdown
Contributor

Should these two be folders, hence ".recommenders/"?

@rhauch

rhauch commented Oct 2, 2015

Copy link
Copy Markdown
Contributor Author

@guozhangwang, the leading / is used to say the rule only applies to a top-level directory. But a trailing / is optional (e.g., see .svn, .settings, etc.).

@asfgit asfgit closed this in b56e02b Oct 2, 2015
@guozhangwang

Copy link
Copy Markdown
Contributor

Thanks for the explanation, LGTM.

@rhauch rhauch deleted the kafka-2597 branch October 27, 2015 15:07
jsancio pushed a commit to jsancio/kafka that referenced this pull request Aug 6, 2019
omkreddy pushed a commit to omkreddy/kafka that referenced this pull request Feb 15, 2021
Reviewers: Ismael Juma <ismael@juma.me.uk>
wyuka pushed a commit to wyuka/kafka that referenced this pull request Feb 4, 2022
wyuka pushed a commit to wyuka/kafka that referenced this pull request Feb 4, 2022
…he#261)

TICKET = N/A
LI_DESCRIPTION =
The previous PR apache#259 added logic to retry failed tests for the `test` gradle task.
This PR adds the retries for the `integrationTest` and `unitTest` tasks as well.

This change is tested by adding a test that always fails,
and verifying that the command below will retry the test for 3 times after the failure.
export SCALA_VERSION=2.12 && ./gradlew -PmaxTestRetries=3 -PscalaVersion="$SCALA_VERSION" -PtestLoggingEvents=started,passed,skipped,failed --no-daemon core:integrationTest --rerun-tasks --tests '*.lucasTest'
EXIT_CRITERIA = N/A
traceyyoshima added a commit to traceyyoshima/kafka that referenced this pull request May 17, 2026
…pache#259)

Refreshed snapshot. Seven language-engine PRs landed this session:

- PR apache#253 — Annotation paren anchor for continuation slots
- PR apache#254 — StructuralBody2x catalog class for inline lambda bodies
- PR apache#255 — Lambda body as continuation enclosing scope
- PR apache#256 — Inline-lambda body close brace catalog
- PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot
- PR apache#258 — alignmentTargets restricted to OWNER's prefix slot
- PR apache#259 — Chain wrap preservation when siblings agree on column

Sweep stats (post-apache#259):
  files scanned : 5,834
  files changed : 990 (17.0%)     [initial PR #6: 1,038]
  byte delta    : -10,685          [initial PR #6: -6,661]
  reformat time : ~7s total

Most called-out files from the user's original review now fully
closed:
  - ShareConsumerTest (body + close brace)
  - ProducerIdExpirationTest
  - DeleteAclsResponse
  - CustomQuotaCallbackTest
  - AsyncKafkaConsumerTest (body indent regression)
  - AdminClientConfig L273/L282
  - WriteTxnMarkersRequest L135
  - TxnOffsetCommitRequest L156-159
  - RequestResponseTest chain shifts
  - AlterReplicaLogDirsRequestTest (cascade-closed)

Remaining residuals (~5 files, small):
  - StreamsResetter L580 (single `||` continuation normalisation)
  - ClientUtilsTest L79/L143 (continuation normalisation)
  - LeaveGroupRequestTest L55 (continuation shift)
  - LeaveGroupResponseTest (trailing-ws on blank lines)
  - ReassignPartitionsUnitTest (single line)

These are mostly the formatter normalising slightly non-standard
source — not really bugs.
traceyyoshima added a commit to traceyyoshima/kafka that referenced this pull request May 17, 2026
…pache#260)

Refreshed snapshot. Eight language-engine PRs landed this session:

- PR apache#253 — Annotation paren anchor for continuation slots
- PR apache#254 — StructuralBody2x catalog class for inline lambda bodies
- PR apache#255 — Lambda body as continuation enclosing scope
- PR apache#256 — Inline-lambda body close brace catalog
- PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot
- PR apache#258 — alignmentTargets restricted to OWNER's prefix slot
- PR apache#259 — Chain wrap preservation when siblings agree on column
- PR apache#260 — Binary OPERATOR_PREFIX consults outermost binary's anchor

Sweep stats (post-apache#260):
  files scanned : 5,834
  files changed : 989 (17.0%)     [initial PR #6: 1,038]
  byte delta    : -10,663
  reformat time : ~7s total

Almost all called-out files from the user's original review now
fully closed. Remaining residuals (<5 files) are correct
normalisations of slightly non-standard source or trailing
whitespace inside comment content (intentionally out of scope for
this engine version per user design choice).
traceyyoshima added a commit to traceyyoshima/kafka that referenced this pull request May 17, 2026
…pache#261)

Refreshed snapshot. Nine language-engine PRs landed this session:

- PR apache#253 — Annotation paren anchor for continuation slots
- PR apache#254 — StructuralBody2x catalog class for inline lambda bodies
- PR apache#255 — Lambda body as continuation enclosing scope
- PR apache#256 — Inline-lambda body close brace catalog
- PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot
- PR apache#258 — alignmentTargets restricted to OWNER's prefix slot
- PR apache#259 — Chain wrap preservation when siblings agree on column
- PR apache#260 — Binary OPERATOR_PREFIX consults outermost binary's anchor
- PR apache#261 — Nested continuation slots use innermost enclosing scope

Sweep stats (post-apache#261):
  files scanned : 5,834
  files changed : 986 (16.9%)     [initial PR #6: 1,038]
  byte delta    : -11,137          [initial PR #6: -6,661]
  reformat time : ~7s total

PR #7 review comments status:
  - Comments 1+2 closed (PR apache#261)
  - Comments 3 + 4/5 deferred (workbench-first investigation; diagnosis
    captured in language-engine memory project_pr7_deferred_comments_2026_05_17.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants