KAFKA-2588 ReplicaManager partitionCount metric should actually be re…#254
KAFKA-2588 ReplicaManager partitionCount metric should actually be re…#254granthenke wants to merge 1 commit into
Conversation
|
test this. |
|
@granthenke Could you update the documentation as well? |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
This is the same behavior we configured for PR builds in Apache Kafka. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>
|
Thanks for the patch. I'm going to close this for now since it requires a KIP, but please consider reopening if you (or anyone else) has time to submit a proposal. (The change does seem reasonable to me for what it's worth.) |
…pache#257) Refreshed snapshot from the kafka format sweep review. Five language-engine PRs landed in this session: - PR apache#253 — Annotation paren anchor for continuation slots - PR apache#254 — StructuralBody2x catalog class for inline lambda bodies - PR apache#255 — Lambda body as continuation enclosing scope - PR apache#256 — Inline-lambda body close brace catalog (+0 / +projectDelta) - PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot Sweep stats (post-apache#257): files scanned : 5,834 files changed : 1,027 (17.6%) [initial PR #6: 1,038] byte delta : -10,877 [initial PR #6: -6,661] reformat time : 7.2s total, 1.23 ms/file The larger byte delta vs. the initial sweep reflects PR apache#257 fixing the AsyncKafkaConsumerTest-style "body at col 48" pattern across multiple files — body statements no longer indent to the inflated close-paren-line column, so each affected line shrinks by 30+ characters. Remaining patterns deferred to subsequent PRs: - Chain-dot over-application on Class.STATIC_FIELD / new X() (AdminClientConfig L273/L282, WriteTxnMarkersRequest L135, TxnOffsetCommitRequest L156/L159) - Partial-shift inconsistencies (StreamsResetter, ClientUtilsTest, RequestResponseTest, LeaveGroupRequest*, AlterReplicaLogDirs) - Trailing-whitespace cleanups on blank lines (incidental noise)
…pache#258) Refreshed snapshot. Six language-engine PRs landed this session: - PR apache#253 — Annotation paren anchor for continuation slots - PR apache#254 — StructuralBody2x catalog class for inline lambda bodies - PR apache#255 — Lambda body as continuation enclosing scope - PR apache#256 — Inline-lambda body close brace catalog (+0 / +projectDelta) - PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot - PR apache#258 — alignmentTargets restricted to OWNER's prefix slot Sweep stats (post-apache#258): files scanned : 5,834 files changed : 1,000 (17.1%) [initial PR #6: 1,038] byte delta : -10,630 [initial PR #6: -6,661] reformat time : 7.1s total, 1.22 ms/file Remaining patterns (deferred): - Outer chain-dot receiver-anchor variations (TxnOffsetCommitRequest L156/L159, RequestResponseTest L3373+, etc.) — separate path from PR apache#258's inner-arg fix - Small continuation normalizations of non-standard source (StreamsResetter, ClientUtilsTest, LeaveGroupRequestTest) - Trailing-whitespace cleanups on blank lines (incidental noise)
…pache#259) Refreshed snapshot. Seven language-engine PRs landed this session: - PR apache#253 — Annotation paren anchor for continuation slots - PR apache#254 — StructuralBody2x catalog class for inline lambda bodies - PR apache#255 — Lambda body as continuation enclosing scope - PR apache#256 — Inline-lambda body close brace catalog - PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot - PR apache#258 — alignmentTargets restricted to OWNER's prefix slot - PR apache#259 — Chain wrap preservation when siblings agree on column Sweep stats (post-apache#259): files scanned : 5,834 files changed : 990 (17.0%) [initial PR #6: 1,038] byte delta : -10,685 [initial PR #6: -6,661] reformat time : ~7s total Most called-out files from the user's original review now fully closed: - ShareConsumerTest (body + close brace) - ProducerIdExpirationTest - DeleteAclsResponse - CustomQuotaCallbackTest - AsyncKafkaConsumerTest (body indent regression) - AdminClientConfig L273/L282 - WriteTxnMarkersRequest L135 - TxnOffsetCommitRequest L156-159 - RequestResponseTest chain shifts - AlterReplicaLogDirsRequestTest (cascade-closed) Remaining residuals (~5 files, small): - StreamsResetter L580 (single `||` continuation normalisation) - ClientUtilsTest L79/L143 (continuation normalisation) - LeaveGroupRequestTest L55 (continuation shift) - LeaveGroupResponseTest (trailing-ws on blank lines) - ReassignPartitionsUnitTest (single line) These are mostly the formatter normalising slightly non-standard source — not really bugs.
…pache#260) Refreshed snapshot. Eight language-engine PRs landed this session: - PR apache#253 — Annotation paren anchor for continuation slots - PR apache#254 — StructuralBody2x catalog class for inline lambda bodies - PR apache#255 — Lambda body as continuation enclosing scope - PR apache#256 — Inline-lambda body close brace catalog - PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot - PR apache#258 — alignmentTargets restricted to OWNER's prefix slot - PR apache#259 — Chain wrap preservation when siblings agree on column - PR apache#260 — Binary OPERATOR_PREFIX consults outermost binary's anchor Sweep stats (post-apache#260): files scanned : 5,834 files changed : 989 (17.0%) [initial PR #6: 1,038] byte delta : -10,663 reformat time : ~7s total Almost all called-out files from the user's original review now fully closed. Remaining residuals (<5 files) are correct normalisations of slightly non-standard source or trailing whitespace inside comment content (intentionally out of scope for this engine version per user design choice).
…pache#261) Refreshed snapshot. Nine language-engine PRs landed this session: - PR apache#253 — Annotation paren anchor for continuation slots - PR apache#254 — StructuralBody2x catalog class for inline lambda bodies - PR apache#255 — Lambda body as continuation enclosing scope - PR apache#256 — Inline-lambda body close brace catalog - PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot - PR apache#258 — alignmentTargets restricted to OWNER's prefix slot - PR apache#259 — Chain wrap preservation when siblings agree on column - PR apache#260 — Binary OPERATOR_PREFIX consults outermost binary's anchor - PR apache#261 — Nested continuation slots use innermost enclosing scope Sweep stats (post-apache#261): files scanned : 5,834 files changed : 986 (16.9%) [initial PR #6: 1,038] byte delta : -11,137 [initial PR #6: -6,661] reformat time : ~7s total PR #7 review comments status: - Comments 1+2 closed (PR apache#261) - Comments 3 + 4/5 deferred (workbench-first investigation; diagnosis captured in language-engine memory project_pr7_deferred_comments_2026_05_17.md)
…plicaCount