Cumulative improvements from PRs #253-#260 (draft, diff review only)#7
Closed
traceyyoshima wants to merge 1 commit into
Closed
Cumulative improvements from PRs #253-#260 (draft, diff review only)#7traceyyoshima wants to merge 1 commit into
traceyyoshima wants to merge 1 commit into
Conversation
traceyyoshima
commented
May 17, 2026
traceyyoshima
left a comment
Owner
Author
There was a problem hiding this comment.
Submitting for review. Git is too slow, need to switch to internal tooling.
Owner
Author
There was a problem hiding this comment.
This should be in scope of the invocation at 249
| setErrorCode(Errors.MISMATCHED_ENDPOINT_TYPE.code()). | ||
| setErrorMessage("The request was sent to an endpoint of type BROKER, " + | ||
| "but we wanted an endpoint of type CONTROLLER"))); | ||
| "but we wanted an endpoint of type CONTROLLER"))); |
Owner
Author
There was a problem hiding this comment.
The binary RHS should have been indented while in the method invocation.
Owner
Author
There was a problem hiding this comment.
This should have an indent, since it's a select on a new class.
Owner
Author
There was a problem hiding this comment.
The arguments should have indented with the invocation
Owner
Author
There was a problem hiding this comment.
The arguments should have been indented
…pache#261) Refreshed snapshot. Nine language-engine PRs landed this session: - PR apache#253 — Annotation paren anchor for continuation slots - PR apache#254 — StructuralBody2x catalog class for inline lambda bodies - PR apache#255 — Lambda body as continuation enclosing scope - PR apache#256 — Inline-lambda body close brace catalog - PR apache#257 — emittedLineStarts restricted to OWNER's prefix slot - PR apache#258 — alignmentTargets restricted to OWNER's prefix slot - PR apache#259 — Chain wrap preservation when siblings agree on column - PR apache#260 — Binary OPERATOR_PREFIX consults outermost binary's anchor - PR apache#261 — Nested continuation slots use innermost enclosing scope Sweep stats (post-apache#261): files scanned : 5,834 files changed : 986 (16.9%) [initial PR #6: 1,038] byte delta : -11,137 [initial PR #6: -6,661] reformat time : ~7s total PR #7 review comments status: - Comments 1+2 closed (PR apache#261) - Comments 3 + 4/5 deferred (workbench-first investigation; diagnosis captured in language-engine memory project_pr7_deferred_comments_2026_05_17.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff view: post-fix state vs initial sweep
This draft PR shows the cumulative improvements the language-engine formatter gained from 8 PRs landed during the 2026-05-17 session, applied to the same kafka source.
engine/format-sweep-2026-05-17): output of the initial sweep, before any fixest3): output of the same sweep after PRs MINOR: Make indenting incheckstyle.xmlandimport-control.xmlconsistent apache/kafka#253-KAFKA-2587:Increasing timeout for the test verification. apache/kafka#260 mergedEach removed line shows what the formatter would have done initially; each added line shows what it does now.
PRs reflected in this diff
Most visible closures
value =continuation closed||continuations in the binary chain now consistently preservedNot for merge; diff inspection only.