7.17.1 by github-actions[bot] · Pull Request #8870 · MetaMask/metamask-mobile

github-actions · 2024-03-06T19:51:37Z

This is the release candidate for version 7.17.1.

## **Description** This PR merges 7.16.0 into 7.17.0 the major conflict that occurred was in the migration files. The PR creates a migration file 29 that applies the changes which were in `main`. - Migration 28 address bug #8578 - Migration 29 represent the work done here #7999 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** This PR cherry-picks #8615 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46e749cb-c149-4ced-bc40-a9e5e1bed3c8 Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/88873d22-4fea-45c3-83f3-eb034aa3ee32 ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** This PR cherry-picks #[8632](#8632) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** Smoke test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/46e749cb-c149-4ced-bc40-a9e5e1bed3c8 Regression test run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/88873d22-4fea-45c3-83f3-eb034aa3ee32 ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.## **Description**  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: MetaMask Bot <37885440+metamaskbot@users.noreply.github.com>

Cherry-pick fix for #8725 on version 7.17.0. Co-authored-by: Jyoti Puri <jyotipuri@gmail.com> Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>

Cherry-pick fix for #8742 on version 7.17.0.

This PR cherry-picks #8744 Co-authored-by: salimtb <salim.toubal@outlook.com>

Cherry-pick fix for #8727 on version 7.17.0.

Cherry-pick fix for #8708 on version 7.17.0. --------- Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>

## **Description** Chore to bump release version ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Jyoti Puri <jyotipuri@gmail.com>

github-actions · 2024-03-06T22:47:30Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sleepytanya · 2024-03-07T23:37:23Z

## **Description** Copied changes from: #8886 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: sethkfman <seth.kaufman@consensys.net> Co-authored-by: Cal-L <cleun007@gmail.com>

cortisiko · 2024-03-12T23:40:05Z

Scenarios:

Prerequisites: 1 custom network added, tokens imported into wallet

Going from 7.14.0 > 7.17.1 is good ✅
Going from 7.16.0 > 7.17.1 is good ✅
Going from 7.14.0 > 7.16.0 > 7.17.1 is good ✅

For the below scenario, I tested with the app killed and NOT when the app was in the background.
Going from 7.14.0 > 7.16.0 > 7.17.0 > 7.17.1 is good ✅

Regression and Smoke E2E tests have passed on this PR as well.

…8933) ## **Description** This PR will fix #8917 for the release 7.17.1. The fix is quite simple to move the `await this.persistTransactionParameters(transaction);` above ledger code in `Confirm/index.js` file so that TransactionController can persist all gas relative tx parameter before ledger process signTransaction. > ⚠️ : Due to `main` branch have TransactionController upgrade which use `@ethereumjs/tx` library, which cause another issue in ledger transaction flow, this PR will not fix the issue on `main` branch, however we should still merge this PR to `main` branch and then i will fix another ledger transaction issue due to `@ethereumjs/tx` upgrade.  ## **Related issues** Fixes: #8917 ## **Manual testing steps** 1. Connect Ledger device 2. Switch network to Linea Testnet 3. Send transaction from Ledger account to Account 2 (normal account) 4. Confirm transaction on Ledger device 5. Transaction should successfully submitted. ## **Screenshots/Recordings**  ### **Before** https://github.com/MetaMask/metamask-mobile/assets/106310394/0ae2fddb-40d1-4b13-af8c-0143525bf28f  ### **After**  https://github.com/MetaMask/metamask-mobile/assets/7315988/326b34a7-904e-4f01-9d18-52c47cd072bc ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [x] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

vivek-consensys · 2024-03-14T17:09:44Z

Ledger sanity test flows completed on both iOS and Android on the RC3 build, which include:-

Connect Ledger
Disconnect Ledger
Send transaction using Ledger device
Swap transaction using Ledger device
Eth sign, personal sign, sign typed data v4, sign permit and siwe using Ledger device (test-dapp)

cortisiko · 2024-03-14T20:50:29Z

7.17.1 (1280) is QA passed ✅ ✅

## **Description**  Merge main into 7.17.1 ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

sonarqubecloud · 2024-03-15T20:23:36Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov-commenter · 2024-03-15T20:23:45Z

Codecov Report

Attention: Patch coverage is 64.42953% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 43.75%. Comparing base (1630a58) to head (a6c0f3a).

Files	Patch %	Lines
app/store/migrations/031.ts	65.33%	9 Missing and 17 partials ⚠️
app/store/migrations/029.ts	63.23%	8 Missing and 17 partials ⚠️
...ents/Views/confirmations/SendFlow/Confirm/index.js	0.00%	1 Missing ⚠️
app/store/migrations/030.ts	80.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8870      +/-   ##
==========================================
+ Coverage   43.67%   43.75%   +0.07%     
==========================================
  Files        1271     1271              
  Lines       30921    31055     +134     
  Branches     3092     3148      +56     
==========================================
+ Hits        13506    13587      +81     
- Misses      16636    16657      +21     
- Partials      779      811      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cal-L

LGTM

metamaskbot and others added 12 commits February 16, 2024 19:41

7.17.0

b6667ce

updated changelog

1c678b7

fix: cherry-pick (#8725) (#8767)

e0b5f71

Cherry-pick fix for #8725 on version 7.17.0. Co-authored-by: Jyoti Puri <jyotipuri@gmail.com> Co-authored-by: sethkfman <10342624+sethkfman@users.noreply.github.com>

fix: cherry-pick (#8742) (#8765)

9c11aac

Cherry-pick fix for #8742 on version 7.17.0.

chore: cherry-pick #8744 (#8757)

3f48fe2

This PR cherry-picks #8744 Co-authored-by: salimtb <salim.toubal@outlook.com>

fix: cherry-pick (#8727) (#8766)

bf433de

Cherry-pick fix for #8727 on version 7.17.0.

chore: cherry-pick #8708 (#8760)

5e2d228

Cherry-pick fix for #8708 on version 7.17.0. --------- Co-authored-by: Sylva Elendu <iamsylvaelendu@gmail.com>

7.17.1

cc5df3f

metamaskbot added the release-7.17.1 Issue or pull request that will be included in release 7.17.1 label Mar 6, 2024

metamaskbot mentioned this pull request Mar 6, 2024

[Bug]: User input for custom gas is ignored #8708

Closed

updated changelog

047e3fe

tommasini and others added 3 commits March 12, 2024 19:15

1277 version bump for RC 2

68b4b6f

update changelog

8cf81c0

dawnseeker8 and others added 2 commits March 14, 2024 14:51

sethkfman marked this pull request as ready for review March 14, 2024 22:44

sethkfman requested a review from a team as a code owner March 14, 2024 22:44

github-actions Bot requested a review from a team as a code owner March 15, 2024 20:03

Merge branch 'main' into release/7.17.1

a6c0f3a

sethkfman added the QA Passed QA testing has been completed and passed label Mar 15, 2024

Cal-L added the team-mobile-platform Mobile Platform team label Mar 15, 2024

Cal-L approved these changes Mar 15, 2024

View reviewed changes

Cal-L merged commit 02eef8b into main Mar 15, 2024

github-actions Bot locked and limited conversation to collaborators Mar 15, 2024

metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

7.17.1#8870

7.17.1#8870
Cal-L merged 21 commits into
mainfrom
release/7.17.1

github-actions Bot commented Mar 6, 2024

Uh oh!

github-actions Bot commented Mar 6, 2024

Uh oh!

sleepytanya commented Mar 7, 2024 •

edited

Loading

Uh oh!

cortisiko commented Mar 12, 2024

Uh oh!

vivek-consensys commented Mar 14, 2024

Uh oh!

cortisiko commented Mar 14, 2024

Uh oh!

sonarqubecloud Bot commented Mar 15, 2024

Uh oh!

codecov-commenter commented Mar 15, 2024

Uh oh!

Cal-L left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Conversation

github-actions Bot commented Mar 6, 2024

Uh oh!

github-actions Bot commented Mar 6, 2024

Uh oh!

sleepytanya commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cortisiko commented Mar 12, 2024

Scenarios:

Uh oh!

vivek-consensys commented Mar 14, 2024

Uh oh!

cortisiko commented Mar 14, 2024

Uh oh!

sonarqubecloud Bot commented Mar 15, 2024

Quality Gate passed

Uh oh!

codecov-commenter commented Mar 15, 2024

Codecov Report

Uh oh!

Cal-L left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

sleepytanya commented Mar 7, 2024 •

edited

Loading