-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Bug]: User input for custom gas is ignored #8708
Copy link
Copy link
Closed
Labels
LedgerLedger hardware wallet related issue or developmentLedger hardware wallet related issue or developmentSev1-highAn issue that may have caused fund loss or access to wallet in the past & may still be ongoingAn issue that may have caused fund loss or access to wallet in the past & may still be ongoingregression-RCDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadregression-RC-7.17.0regression-prod-7.16.0Regression bug that was found in production in release 7.16.0Regression bug that was found in production in release 7.16.0release-7.17.0Issue or pull request that will be included in release 7.17.0Issue or pull request that will be included in release 7.17.0release-blockerThis bug is blocking the next releaseThis bug is blocking the next releaseteam-confirmationsPush issues to confirmations teamPush issues to confirmations teamteam-confirmations-system-deprecatedDEPRECATED: please use "team-confirmations" insteadDEPRECATED: please use "team-confirmations" insteadtype-bugSomething isn't workingSomething isn't working
Metadata
Metadata
Assignees
Labels
LedgerLedger hardware wallet related issue or developmentLedger hardware wallet related issue or developmentSev1-highAn issue that may have caused fund loss or access to wallet in the past & may still be ongoingAn issue that may have caused fund loss or access to wallet in the past & may still be ongoingregression-RCDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadregression-RC-7.17.0regression-prod-7.16.0Regression bug that was found in production in release 7.16.0Regression bug that was found in production in release 7.16.0release-7.17.0Issue or pull request that will be included in release 7.17.0Issue or pull request that will be included in release 7.17.0release-blockerThis bug is blocking the next releaseThis bug is blocking the next releaseteam-confirmationsPush issues to confirmations teamPush issues to confirmations teamteam-confirmations-system-deprecatedDEPRECATED: please use "team-confirmations" insteadDEPRECATED: please use "team-confirmations" insteadtype-bugSomething isn't workingSomething isn't working
Type
Fields
Give feedbackNo fields configured for issues without a type.
Describe the bug
I noticed when trying to test speed up and cancel that any input I make and save on the custom gas screen is simply ignored in what is broadcast to network on Sepolia as well as on mainnet in 7.16.0
Initially observed with Ledger in RC 7.17.0, also observed on QR and HD accounts.
Whether I edit custom gas amounts, or choose the preselected
Aggressiveoption, my input is ignored and the original market amount is what is submitted to the network on Sepolia as well as Mainnet.I am aware of a similar issue being actively worked for Linea Goerli here
Expected behavior
Given that I am conducting a tx
When I tap gas to edit
And I save custom gas values
Then the custom amount I save is what is sent to network
Screenshots/Recordings
Custom input:
CustomGasInputIgnored.mov
https://sepolia.etherscan.io/tx/0xcd6c65d069baa8748899f5804258fac1fb7c5ed37c6f4ad5d1b8fb5fa31a8a54
Using aggressive:
AggressiveIgnored.mov
https://sepolia.etherscan.io/tx/0x9ea35755188cb301d94881eb070fb9135a02c1cc008e3402a8b1a38ae11998e9
Mainnet:
I failed to capture a recording, but I submitted the following tx with custom input of 2 wei max priority fee and 1 wei max fee, and it appears in etherscan at the original suggested market rates:
https://etherscan.io/tx/0x7cfce9e6413b0619013b3de5fd5a040bd73e6353c7b81db58fed0573a43b7b23
Steps to reproduce
Custom input:
Advanced optionsSaveView on EtherscanAggressive:
AggressiveError messages or log output
No response
Version
7.16.0
Build type
None
Device
iPhone Xs ios 17.3.1
Operating system
iOS
Additional context
This was initially discoverd in 7.17.0 RC testing, but can be observed in production 7.16.0. Given the undermining of trust by failing to honor user input I have marked this as a release blocker for 7.17.0, but feel free to adjust that as necy.
Notably, this is making it incredibly challenging if not impossible to test speed up/cancel transactions for the Ledger integration which is included in 7.17.0 RC.
Severity
Not many people may use this feature but for those that try, the severity of this defect is high.