Skip to content

[Bug]: User input for custom gas is ignored #8708

@plasmacorral

Description

@plasmacorral

Describe the bug

I noticed when trying to test speed up and cancel that any input I make and save on the custom gas screen is simply ignored in what is broadcast to network on Sepolia as well as on mainnet in 7.16.0

Initially observed with Ledger in RC 7.17.0, also observed on QR and HD accounts.

Whether I edit custom gas amounts, or choose the preselected Aggressive option, my input is ignored and the original market amount is what is submitted to the network on Sepolia as well as Mainnet.

I am aware of a similar issue being actively worked for Linea Goerli here

Expected behavior

Given that I am conducting a tx
When I tap gas to edit
And I save custom gas values
Then the custom amount I save is what is sent to network

Screenshots/Recordings

Custom input:

CustomGasInputIgnored.mov

https://sepolia.etherscan.io/tx/0xcd6c65d069baa8748899f5804258fac1fb7c5ed37c6f4ad5d1b8fb5fa31a8a54

Using aggressive:

AggressiveIgnored.mov

https://sepolia.etherscan.io/tx/0x9ea35755188cb301d94881eb070fb9135a02c1cc008e3402a8b1a38ae11998e9

Mainnet:
I failed to capture a recording, but I submitted the following tx with custom input of 2 wei max priority fee and 1 wei max fee, and it appears in etherscan at the original suggested market rates:
https://etherscan.io/tx/0x7cfce9e6413b0619013b3de5fd5a040bd73e6353c7b81db58fed0573a43b7b23

Steps to reproduce

Custom input:

  1. Have a wallet setup
  2. Be on Sepolia and have testnet assets (preferably, but can also observe on mainnet)
  3. Start a send tx
  4. Select a destination address
  5. Set an amount
  6. On the confirmation screen tap the blue link on the estimated gas fee
  7. On edit priority, tap Advanced options
  8. For max priority enter any amount less than what was populated but more than 0.000000002 (2 wei)
  9. For max fee enter any amount less than what was populated but more than 0.000000001 (1 wei)
  10. Tap Save
  11. Tap to confirm
  12. Once returned to wallet view tap on the asset under tokens
  13. scroll to the pending tx and tap on it
  14. In the tx details, tap to View on Etherscan
  15. Once confirmed, note that gas values do not match user input'

Aggressive:

  1. Have a wallet setup
  2. Be on Sepolia and have testnet assets
  3. Start a send tx
  4. Select a destination address
  5. Set an amount
  6. On the confirmation screen tap the blue link on the estimated gas fee
  7. On edit priority select Aggressive
  8. Save
  9. Send
  10. Note that TX fee is less than the estimated gas fee at market rates, and is significantly lower than the estimated gas for the Aggressive option

Error messages or log output

No response

Version

7.16.0

Build type

None

Device

iPhone Xs ios 17.3.1

Operating system

iOS

Additional context

This was initially discoverd in 7.17.0 RC testing, but can be observed in production 7.16.0. Given the undermining of trust by failing to honor user input I have marked this as a release blocker for 7.17.0, but feel free to adjust that as necy.

Notably, this is making it incredibly challenging if not impossible to test speed up/cancel transactions for the Ledger integration which is included in 7.17.0 RC.

Severity

Not many people may use this feature but for those that try, the severity of this defect is high.

Metadata

Metadata

Assignees

Labels

LedgerLedger hardware wallet related issue or developmentSev1-highAn issue that may have caused fund loss or access to wallet in the past & may still be ongoingregression-RCDEPRECATED: Please use "regresssion-RC-x.y.z" label insteadregression-RC-7.17.0regression-prod-7.16.0Regression bug that was found in production in release 7.16.0release-7.17.0Issue or pull request that will be included in release 7.17.0release-blockerThis bug is blocking the next releaseteam-confirmationsPush issues to confirmations teamteam-confirmations-system-deprecatedDEPRECATED: please use "team-confirmations" insteadtype-bugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions