Skip to content

fix: update PPOM to v1.4.4#8863

Merged
jpuri merged 1 commit into
mainfrom
ppom_update_1.4.4
Mar 6, 2024
Merged

fix: update PPOM to v1.4.4#8863
jpuri merged 1 commit into
mainfrom
ppom_update_1.4.4

Conversation

@jpuri

@jpuri jpuri commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

Description

Update PPOM to v1.4.4

Related issues

Fixes:

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri requested a review from a team as a code owner March 6, 2024 14:32
@github-actions

github-actions Bot commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Mar 6, 2024
@github-actions

github-actions Bot commented Mar 6, 2024 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2ff2707
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef317472-c01b-49a1-ba68-3d4420b453d0

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jpuri

jpuri commented Mar 6, 2024

Copy link
Copy Markdown
Contributor Author

bitrise build passed: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ef317472-c01b-49a1-ba68-3d4420b453d0

@jpuri jpuri merged commit 19c0ea0 into main Mar 6, 2024
@jpuri jpuri deleted the ppom_update_1.4.4 branch March 6, 2024 15:54
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 6, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 6, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cryptotavares cryptotavares cryptotavares approved these changes

+1 more reviewer

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.19.0 Issue or pull request that will be included in release 7.19.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpuri @cryptotavares @blackdevelopa @metamaskbot