Skip to content

fix: Tokens disappearing#8892

Merged
tommasini merged 8 commits into
release/7.17.1from
fix/migrations-cherry-pick
Mar 12, 2024
Merged

fix: Tokens disappearing#8892
tommasini merged 8 commits into
release/7.17.1from
fix/migrations-cherry-pick

Conversation

@tommasini

@tommasini tommasini commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Description

Copied changes from: #8886

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team labels Mar 8, 2024
@tommasini tommasini requested a review from a team as a code owner March 8, 2024 21:26
@github-actions

github-actions Bot commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter

codecov-commenter commented Mar 8, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 63.63636% with 56 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/7.17.1@047e3fe). Click here to learn what that means.

Files Patch % Lines
app/store/migrations/031.ts 63.52% 14 Missing and 17 partials ⚠️
app/store/migrations/029.ts 63.23% 8 Missing and 17 partials ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##             release/7.17.1    #8892   +/-   ##
=================================================
  Coverage                  ?   41.27%           
=================================================
  Files                     ?     1250           
  Lines                     ?    30597           
  Branches                  ?     3037           
=================================================
  Hits                      ?    12630           
  Misses                    ?    17184           
  Partials                  ?      783

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexHerman1 AlexHerman1 added CS-reported issues reported by CS CS-tracking issues being tracked by / relevant to CS labels Mar 12, 2024
@metamaskbot metamaskbot added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 12, 2024
Cal-L
Cal-L approved these changes Mar 12, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cortisiko
cortisiko approved these changes Mar 12, 2024
View reviewed changes

@cortisiko cortisiko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is QA passed!

@tommasini tommasini merged commit dfed428 into release/7.17.1 Mar 12, 2024
@tommasini tommasini deleted the fix/migrations-cherry-pick branch March 12, 2024 19:15
@sonarqubecloud

sonarqubecloud Bot commented Mar 12, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions github-actions Bot removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Mar 12, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2024
@metamaskbot metamaskbot added in-progress release-7.17.1 Issue or pull request that will be included in release 7.17.1 labels Mar 12, 2024
@metamaskbot

metamaskbot commented Mar 15, 2024

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.17.1 on PR, as PR was added to branch 7.17.1 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

@cortisiko cortisiko cortisiko approved these changes

Assignees

No one assigned

Labels

CS-reported issues reported by CS CS-tracking issues being tracked by / relevant to CS in-progress release-7.17.1 Issue or pull request that will be included in release 7.17.1 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tommasini @codecov-commenter @metamaskbot @Cal-L @cortisiko @AlexHerman1 @sethkfman