Skip to content

fix: Tokens disappearing#8886

Closed
tommasini wants to merge 3 commits into
mainfrom
fix/tokens-disappearing
Closed

fix: Tokens disappearing#8886
tommasini wants to merge 3 commits into
mainfrom
fix/tokens-disappearing

Conversation

@tommasini

@tommasini tommasini commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

Description

  • This PR includes migrating the values on the store regarding tokens to hexadecimal format
  • Fixes migrations needed to be async for those who updates from 7.14.0 and further since there were async operations
  • This PR also adds a migration to the ones that didn't import any tokens and were impacted on 7.17.0 for the missing migration values, it will convert those and is would be like the user never suffered from this impact

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

7.14.0 -> 7.17.1 : https://recordit.co/5m4fclB7zw

7.16.0 -> 7.17.1 : https://recordit.co/lkTNPJqrTB

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…al, created migration 33 to the users impacted by the missing migrated data on migration 29
@github-actions

github-actions Bot commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud

sonarqubecloud Bot commented Mar 8, 2024

Copy link
Copy Markdown

@tommasini tommasini added team-mobile-platform Mobile Platform team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 8, 2024
@tommasini tommasini marked this pull request as ready for review March 8, 2024 16:36
@tommasini tommasini requested a review from a team as a code owner March 8, 2024 16:36
@github-actions

github-actions Bot commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 094b0b1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/1b58537d-d396-4c6f-9227-f200fa5a3521

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini added a commit that referenced this pull request Mar 8, 2024
@tommasini tommasini mentioned this pull request Mar 8, 2024
13 tasks
tommasini added a commit that referenced this pull request Mar 12, 2024
## **Description**

Copied changes from:
#8886

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've clearly explained what problem this PR is solving and how it
is solved.
- [ ] I've linked related issues
- [ ] I've included manual testing steps
- [ ] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [ ] I’ve properly set the pull request status:
  - [ ] In case it's not yet "ready for review", I've set it to "draft".
- [ ] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: sethkfman <seth.kaufman@consensys.net>
Co-authored-by: Cal-L <cleun007@gmail.com>
@tommasini tommasini closed this Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant