Skip to content

fix: update PPOM to v1.4.4 (#8863)#8871

Merged
sethkfman merged 1 commit into
release/7.17.1from
cherry-pick-ppom
Mar 6, 2024
Merged

fix: update PPOM to v1.4.4 (#8863)#8871
sethkfman merged 1 commit into
release/7.17.1from
cherry-pick-ppom

Conversation

@seaona

@seaona seaona commented Mar 6, 2024

Copy link
Copy Markdown
Member

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

Copy link
Copy Markdown

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/compat-data@7.22.20 None 0 64.1 kB nicolo-ribaudo
npm/@babel/parser@7.24.0 None 0 1.88 MB nicolo-ribaudo
npm/@babel/preset-env@7.22.20 environment Transitive: filesystem, shell, unsafe +164 17.7 MB nicolo-ribaudo
npm/@babel/template@7.24.0 Transitive: environment +14 2.18 MB nicolo-ribaudo
npm/@babel/types@7.23.0 environment +3 2.5 MB nicolo-ribaudo
npm/@blockaid/ppom_release@1.4.4 network 0 3.08 MB blockaiduser
npm/@jridgewell/gen-mapping@0.3.5 None +4 370 kB jridgewell
npm/@jridgewell/set-array@1.2.1 None 0 17.9 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.25 None +2 270 kB jridgewell
npm/@types/estree@1.0.2 None 0 25.7 kB types
npm/browserslist@4.23.0 environment, filesystem Transitive: shell +6 2.4 MB ai
npm/caniuse-lite@1.0.30001594 None 0 1.99 MB caniuse-lite
npm/core-js-compat@3.32.2 Transitive: environment, filesystem, shell +7 3.08 MB zloirock
npm/electron-to-chromium@1.4.693 None 0 278 kB kilianvalkhof
npm/html-inline-script-webpack-plugin@3.2.1 Transitive: environment, eval, filesystem, network, shell, unsafe +107 23.1 MB icelam
npm/node-releases@2.0.14 None 0 34 kB chicoxyzzy
npm/resolve@1.22.6 environment, filesystem +5 216 kB ljharb

🚮 Removed packages: npm/@babel/preset-env@7.22.6, npm/@blockaid/ppom_release@1.2.8, npm/babel-loader@9.1.2, npm/html-inline-script-webpack-plugin@3.2.0, npm/webpack@5.88.1, npm/zxcvbn@4.4.2

View full report↗︎

@socket-security

Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
New author npm/flat-cache@3.1.0

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/flat-cache@3.1.0

@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@seaona

seaona commented Mar 6, 2024

Copy link
Copy Markdown
Member Author

This has been tested and has QA pass. Here vid evidence

@seaona seaona marked this pull request as ready for review March 6, 2024 20:49
@seaona seaona requested a review from a team as a code owner March 6, 2024 20:49
@seaona seaona added the QA Passed QA testing has been completed and passed label Mar 6, 2024
@github-actions

github-actions Bot commented Mar 6, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f978c172-2e48-4e19-a27a-6c09e9f2c475
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sethkfman

Copy link
Copy Markdown
Contributor

@SocketSecurity ignore npm/flat-cache@3.1.0 review by the PPOM team.

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit b9bdd1e into release/7.17.1 Mar 6, 2024
@sethkfman sethkfman deleted the cherry-pick-ppom branch March 6, 2024 22:47
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 6, 2024
@metamaskbot metamaskbot added the release-7.17.1 Issue or pull request that will be included in release 7.17.1 label Mar 15, 2024
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.17.1 on PR, as PR was added to branch 7.17.1 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-7.17.1 Issue or pull request that will be included in release 7.17.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants