Skip to content

fix: migration to enable Blockaid by default#8727

Merged
blackdevelopa merged 5 commits into
mainfrom
8669/enable_blockaid_default_migration
Feb 27, 2024
Merged

fix: migration to enable Blockaid by default#8727
blackdevelopa merged 5 commits into
mainfrom
8669/enable_blockaid_default_migration

Conversation

@blackdevelopa

@blackdevelopa blackdevelopa commented Feb 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Migrating from a previous version to v7.17.0 should enable Blockaid by default in the same way it's done with 7.17.0 fresh installs.

Related issues

Fixes: #8669

Manual testing steps

  1. Install v7.16
  2. Update to v7.17
  3. Check settings --> see Blockaid is enabled

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@blackdevelopa blackdevelopa changed the title Migration to enable Blockaid by default fix: migration to enable Blockaid by default Feb 26, 2024
@blackdevelopa blackdevelopa added team-confirmations-secure-ux-PR PR from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 26, 2024
@blackdevelopa blackdevelopa self-assigned this Feb 26, 2024
@blackdevelopa blackdevelopa marked this pull request as ready for review February 26, 2024 12:39
@blackdevelopa blackdevelopa requested a review from a team as a code owner February 26, 2024 12:39
@github-actions

github-actions Bot commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0d2ebc9a-2adb-4509-a5b4-bc4e360d8687
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@codecov-commenter

codecov-commenter commented Feb 26, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 41.41%. Comparing base (23ba8b1) to head (afd622d).

❗ Current head afd622d differs from pull request most recent head 852766d. Consider uploading reports for the commit 852766d to get more accurate results

Files Patch % Lines
app/store/migrations/031.ts 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8727      +/-   ##
==========================================
+ Coverage   41.39%   41.41%   +0.02%     
==========================================
  Files        1269     1270       +1     
  Lines       30810    30826      +16     
  Branches     3037     3042       +5     
==========================================
+ Hits        12755    12768      +13     
- Misses      17293    17295       +2     
- Partials      762      763       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segun segun added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 26, 2024
digiwand
digiwand reviewed Feb 26, 2024
View reviewed changes
Comment thread app/store/migrations/030.test.ts Outdated
tommasini
tommasini requested changes Feb 27, 2024
View reviewed changes

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write tests for the captureException

Comment thread app/store/migrations/030.test.ts Outdated
tommasini
tommasini requested changes Feb 27, 2024
View reviewed changes
Comment thread app/store/migrations/030.ts Outdated
tommasini
tommasini previously approved these changes Feb 27, 2024
View reviewed changes

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jpuri
jpuri previously approved these changes Feb 27, 2024
View reviewed changes
@blackdevelopa blackdevelopa dismissed stale reviews from tommasini and jpuri via 824fcad February 27, 2024 13:07
@blackdevelopa blackdevelopa force-pushed the 8669/enable_blockaid_default_migration branch from 4059fa3 to 824fcad Compare February 27, 2024 13:07
@blackdevelopa blackdevelopa force-pushed the 8669/enable_blockaid_default_migration branch from 824fcad to 60d17d2 Compare February 27, 2024 13:17
@sonarqubecloud

sonarqubecloud Bot commented Feb 27, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
88.5% Coverage on New Code
45.6% Duplication on New Code

See analysis details on SonarCloud

@blackdevelopa blackdevelopa merged commit ebf7c1c into main Feb 27, 2024
@blackdevelopa blackdevelopa deleted the 8669/enable_blockaid_default_migration branch February 27, 2024 14:35
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 27, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 27, 2024
@metamaskbot metamaskbot added release-7.18.0 Issue or pull request that will be included in release 7.18.0 and removed release-7.18.0 Issue or pull request that will be included in release 7.18.0 labels Feb 27, 2024
@metamaskbot

metamaskbot commented Feb 29, 2024

Copy link
Copy Markdown
Collaborator

More than one release label on PR. Keeping the lowest one (release-7.17.0) on PR and removing other release labels (release-7.18.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bschorchit bschorchit bschorchit left review comments

@jpuri jpuri jpuri approved these changes

@digiwand digiwand Awaiting requested review from digiwand

@tommasini tommasini Awaiting requested review from tommasini

+1 more reviewer

@segun segun segun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@blackdevelopa blackdevelopa

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Migrating to v7.17.0 does not enable Blockaid by default

8 participants

@blackdevelopa @codecov-commenter @metamaskbot @segun @jpuri @digiwand @bschorchit @tommasini