Description

This PR will fix #8917 for the release 7.17.1.

The fix is quite simple to move the await this.persistTransactionParameters(transaction); above ledger code in Confirm/index.js file so that TransactionController can persist all gas relative tx parameter before ledger process signTransaction.

⚠️ : Due to main branch have TransactionController upgrade which use @ethereumjs/tx library, which cause another issue in ledger transaction flow, this PR will not fix the issue on main branch, however we should still merge this PR to main branch and then i will fix another ledger transaction issue due to @ethereumjs/tx upgrade.

Related issues

Fixes: #8917

Manual testing steps

1. Connect Ledger device
2. Switch network to Linea Testnet
3. Send transaction from Ledger account to Account 2 (normal account)
4. Confirm transaction on Ledger device
5. Transaction should successfully submitted.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.