Skip to content

chore: cherry-pick #8708#8760

Merged
sethkfman merged 2 commits into
release/7.17.0from
fix/8708-custom-gas-ignored-cherry-pick
Feb 29, 2024
Merged

chore: cherry-pick #8708#8760
sethkfman merged 2 commits into
release/7.17.0from
fix/8708-custom-gas-ignored-cherry-pick

Conversation

@matthewwalsh0

@matthewwalsh0 matthewwalsh0 commented Feb 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Cherry-pick fix for #8708 on version 7.17.0.

@matthewwalsh0 matthewwalsh0 requested a review from a team as a code owner February 28, 2024 01:06
@matthewwalsh0 matthewwalsh0 added team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead Run Smoke E2E labels Feb 28, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 28, 2024
@github-actions

github-actions Bot commented Feb 28, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/89aabe9b-f13c-4380-b716-5d7ce6160a71
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Cal-L
Cal-L approved these changes Feb 28, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sethkfman
sethkfman approved these changes Feb 29, 2024
View reviewed changes

@sethkfman sethkfman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackdevelopa blackdevelopa force-pushed the fix/8708-custom-gas-ignored-cherry-pick branch from e1f75a3 to f6a2ccf Compare February 29, 2024 16:16
@github-actions

github-actions Bot commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarqubecloud

sonarqubecloud Bot commented Feb 29, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
47.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter

codecov-commenter commented Feb 29, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/7.17.0@bf433de). Click here to learn what that means.

Files Patch % Lines
...ents/Views/confirmations/SendFlow/Confirm/index.js 47.36% 10 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                @@
##             release/7.17.0    #8760   +/-   ##
=================================================
  Coverage                  ?   41.16%           
=================================================
  Files                     ?     1249           
  Lines                     ?    30443           
  Branches                  ?     2975           
=================================================
  Hits                      ?    12532           
  Misses                    ?    17162           
  Partials                  ?      749

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethkfman sethkfman merged commit 5e2d228 into release/7.17.0 Feb 29, 2024
@sethkfman sethkfman deleted the fix/8708-custom-gas-ignored-cherry-pick branch February 29, 2024 16:35
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 29, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 29, 2024
@metamaskbot

metamaskbot commented Feb 29, 2024

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.17.0 on PR, as PR was cherry-picked in branch 7.17.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@Cal-L Cal-L Cal-L approved these changes

+1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@matthewwalsh0 @codecov-commenter @metamaskbot @OGPoyraz @sethkfman @Cal-L @blackdevelopa