Skip to content

fix: change in blockaid alert message#8725

Merged
jpuri merged 4 commits into
mainfrom
change_blockaid_alert_msg
Feb 28, 2024
Merged

fix: change in blockaid alert message#8725
jpuri merged 4 commits into
mainfrom
change_blockaid_alert_msg

Conversation

@jpuri

@jpuri jpuri commented Feb 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Change in blockaid alert message.

Related issues

Fixes: #2145

Manual testing steps

  1. Enable blockaid and open test dapp
  2. Submit a benign transaction
  3. Check message after validation completes.

Screenshots/Recordings

Screenshot 2024-02-27 at 2 43 19 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Feb 26, 2024
@jpuri jpuri requested a review from a team as a code owner February 26, 2024 08:14
@github-actions

github-actions Bot commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri changed the title Change in blockaid alert message fix: change in blockaid alert message Feb 26, 2024
blackdevelopa
blackdevelopa previously approved these changes Feb 26, 2024
View reviewed changes
@codecov-commenter

codecov-commenter commented Feb 26, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.38%. Comparing base (01c6724) to head (f5df43a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8725   +/-   ##
=======================================
  Coverage   41.38%   41.38%           
=======================================
  Files        1266     1266           
  Lines       30768    30768           
  Branches     3028     3028           
=======================================
  Hits        12733    12733           
  Misses      17275    17275           
  Partials      760      760

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f9720aab-c9bc-4382-b532-f294f003cd8b
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

segun
segun previously approved these changes Feb 26, 2024
View reviewed changes
digiwand
digiwand previously approved these changes Feb 26, 2024
View reviewed changes
@jpuri jpuri dismissed stale reviews from digiwand, segun, and blackdevelopa via 5199843 February 27, 2024 09:13
@sonarqubecloud

sonarqubecloud Bot commented Feb 27, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jpuri jpuri merged commit 7f214af into main Feb 28, 2024
@jpuri jpuri deleted the change_blockaid_alert_msg branch February 28, 2024 00:01
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 28, 2024
@metamaskbot metamaskbot added release-7.18.0 Issue or pull request that will be included in release 7.18.0 release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Feb 28, 2024
@metamaskbot metamaskbot removed the release-7.18.0 Issue or pull request that will be included in release 7.18.0 label Feb 29, 2024
@metamaskbot

metamaskbot commented Feb 29, 2024

Copy link
Copy Markdown
Collaborator

Missing release label release-7.17.0 on PR. Adding release label release-7.17.0 on PR and removing other release labels(release-7.18.0), as PR was cherry-picked in branch 7.17.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@segun segun Awaiting requested review from segun

2 more reviewers

@digiwand digiwand digiwand approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jpuri @codecov-commenter @metamaskbot @segun @digiwand @blackdevelopa