Conversation
This reverts commit 7696de2.
This reverts commit d783966.
* Update transaction params validation * fixup! Update transaction params validation * Update to/data error message * fixup! Update to/data error message
The `waitUntilCalled` utility now has a timeout. It will now throw an error if the stub is not called enough times, rather than blocking forever. The return type had to be changed to a function, so that we could throw when the timeout is triggered. I tried returning an error that rejected first, but if you don't handle the error synchronously Node.js will consider it to be an unhandled Promise rejected (even if it _is_ handled later on). I worked around this by resolving in the timeout case as well, so that there is never a "deferred" Promise exception in the timeout case. The returned function re-throws the error if it's given. That way there is never any unhandled Promise rejection.
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.4.0 to 10.4.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md) - [Commits](highlightjs/highlight.js@10.4.0...10.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…back to build quote screen while having insufficient funds (#9994)
When the SES lockdown was added in #9729, the lockdown and the Sentry initialization were migrated from the main bundle into separate modules, which were run as separate `<script>` tags. These extra tags were accidentally omitted for `home.html` and `notification.html`. As a result Sentry was not initialized on these pages, so any errors thrown on them would not be collected. They also do not benefit from the SES lockdown. The SES lockdown and Sentry initialization modules have been added to both pages where they were missing.
The SES lockdown added in #9729 had the effect of obfuscating our error messages. Any messages printed to the console would have the error message replaced with the string "Error #" followed by a number. The stack was also updated to point at `lockdown.cjs`, though the original stack was preserved beneath the top stack frame. Marking the `console` API as untamed seems to have fixed both issues. The original error message is now printed to the console, along with the original stack.
The new metrics controller has a `trackEvent` function that was being called unbound, so `this` references were undefined. It is now bound early in both places where it is passed in as a parameter.
On older browsers that don't support `globalThis`[1], the SES lockdown throws an error. The `globalthis` shim has been added to all pages, to the background process, and to the `contentscript`. This should prevent the error on older browsers. [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis#Browser_compatibility
Failures to persist state are now logged in Sentry. Previously they were only logged to the background console.
When you load an extension `.zip` file in Firefox, it fails to load scripts with the `.cjs` file extension. However, it works if you load the extension via the `manifest.json` file instead. After renaming the `lockdown.cjs` file to `lockdown.js`, it works in Firefox in all cases, regardless whether it's loaded by manifest or by `.zip`.
All user-facing changes have been listed.
Version v8.1.8 RC
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
* origin/develop: (22 commits) Fix TokenList component name (#10030) Update `tweetnacl` dependencies (#10028) Rename `lockdown.cjs` to `lockdown.js` (#10026) Revert "Revert "Add SES lockdown to extension webapp (#9729)"" Revert "Revert "Remove redundant babelify (#9945)"" Add hidden tokens to store (#9320) @metamask/inpage-provider@^8.0.0 (#8640) Log persistence errors with Sentry (#10018) Fix SES lockdown on older browsers (#10014) Reapply view quote screen designs (#9905) Fix unbound metrics track function (#10016) Deobfuscate error message (#10012) Add SES lockdown and Sentry to all pages (#10013) Remove web3 injection (#9156) Initialize network controller provider chainId to the appropriate default networks (#9999) Fix Infura network chain IDs (#8629) Prevent props error in swaps gas modal (#10001) Fix 9906 - Prevent unwanted 'no quotes available' message when going back to build quote screen while having insufficient funds (#9994) Fix 9988 - Don't allow more than 15% slippage (#9991) Bump highlight.js from 10.4.0 to 10.4.1 (#10004) ...
tmashuang
approved these changes
Dec 9, 2020
Collaborator
Builds ready [b2aa14d]
Page Load Metrics (510 ± 28 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings
developup-to-date with v8.1.8