Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [6f8958e]
Page Load Metrics (376 ± 57 ms)
|
|
I'm guessing this wasn't supposed to include the revert commits |
6f8958e to
d70b4b9
Compare
|
Below are screenshots of how it currently looks. Some of these require design or implmentation improvements for reasons stated below 👍 Sufficient funds, no warnings, no approval required: 
👍 Insufficient funds warning: 
👎 No warnings, but approval required. In popup view, metamask fee info is hidden below scroll:
👎 Price difference warning. Fee info hidden below the scroll in popup view, and terms of service pushed off screen in full screen view 
|
3c84132 to
3205899
Compare
Builds ready [3205899]
Page Load Metrics (450 ± 43 ms)
|
|
A few tweaks to reduce how often scrolling is needed:
|
|
@jakehaugen LGTM! |
* Update main-quote-summary designs/styles * Clean up css: use className instead of element types * Style fixes to symbol elements in main-quote-view * Use correct source for token iconUrls passed to main-quote-view * Improve vertical spacing on view-quote screen and with new main-quote-view designs * Remove unused classes * Tweak space around large quote amount text in main-quote-summary
* Update fee card designs to show savings and MM fee css touch up More semantic html and remove unnecessary container wrapper Update message for case when there are no savings, in new swaps fee card designs Improve display of tilde in savings designs * Ensure terms of service is shown when insufficient eth warning is shown on view-quote screen * Logic simplification in fee-card.js * Better center info tooltip icons in fee-card * Add comment about use of \!important in fee card css * Use container class property on info tooltip in fee card * Remove function call that was made redundant with 980b140 but not removed during rebase
3205899 to
9efd100
Compare
|
With @jakehaugen's changes:
|
Builds ready [9efd100]
Page Load Metrics (389 ± 50 ms)
|
This is a PR that contains the work reverted in #9904 (which was originally merged with #9612 and #9629
We may still end up using much of this code. This draft PR can be a place for further discussion if necessary, and will be updated as any new design changes are made.