Skip to content

Prevent props error in swaps gas modal#10001

Merged
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:gas-modal-error
Dec 7, 2020
Merged

Prevent props error in swaps gas modal#10001
darkwing merged 1 commit intoMetaMask:developfrom
darkwing:gas-modal-error

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented Dec 4, 2020

Saw this pop up when I was testing something else:

PropsErr

We store this rate as a number so it's just a case of having the wrong type.

@darkwing darkwing requested a review from a team as a code owner December 4, 2020 17:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 4, 2020

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkwing darkwing merged commit 33b15b5 into MetaMask:develop Dec 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants