Skip to content

@metamask/inpage-provider@^8.0.0#8640

Merged
rekmarks merged 6 commits intodevelopfrom
delete-public-config-store
Dec 8, 2020
Merged

@metamask/inpage-provider@^8.0.0#8640
rekmarks merged 6 commits intodevelopfrom
delete-public-config-store

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented May 21, 2020 •
edited
Loading

@rekmarks rekmarks added the DO-NOT-MERGE Pull requests that should not be merged label May 21, 2020
@rekmarks rekmarks changed the title Update inpage provider; delete public config store WIP: Update inpage provider; delete public config store May 21, 2020
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 21, 2020

Builds ready [b9a8bdd]
Page Load Metrics (593 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint328240105
domContentLoaded34375658913364
load34575859313062
domInteractive34375658913364

This was referenced May 21, 2020
Closed
Closed
Gudahtt
Gudahtt reviewed May 26, 2020
View reviewed changes
@rekmarks rekmarks dismissed a stale review via e0caef8 September 16, 2020 22:26
@rekmarks rekmarks force-pushed the delete-public-config-store branch 2 times, most recently from e0caef8 to 7f55ce6 Compare September 18, 2020 21:13
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 18, 2020

Builds ready [7f55ce6]
Page Load Metrics (483 ± 71 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29483453
domContentLoaded30475448214771
load30575648314771
domInteractive30475448214771

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 19, 2020

Builds ready [c7c8fc0]
Page Load Metrics (539 ± 77 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint319147199
domContentLoaded29978253716177
load30178453916177
domInteractive29978253716177

@rekmarks rekmarks force-pushed the delete-public-config-store branch 2 times, most recently from c52b2f3 to 589363e Compare September 19, 2020 06:16
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Sep 19, 2020

Builds ready [589363e]
Page Load Metrics (689 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37118582010
domContentLoaded3811112685209101
load3831117689208100
domInteractive3811112685209101

@danjm danjm added this to the v8.1.next? milestone Nov 3, 2020
@rekmarks rekmarks mentioned this pull request Nov 24, 2020
Merged
@rekmarks rekmarks force-pushed the delete-public-config-store branch from 589363e to bb1ff60 Compare November 24, 2020 22:06
@rekmarks rekmarks mentioned this pull request Nov 24, 2020
Merged
@rekmarks rekmarks changed the title WIP: Update inpage provider; delete public config store Replace publicConfigStore with RPC notifications Nov 24, 2020
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 24, 2020

Builds ready [bb1ff60]
Page Load Metrics (554 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33115612613
domContentLoaded30875855213665
load31075955413665
domInteractive30875855213665

@rekmarks rekmarks force-pushed the delete-public-config-store branch from bb1ff60 to 67efbbc Compare November 26, 2020 00:46
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 26, 2020

Builds ready [67efbbc]
Page Load Metrics (468 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint3394582211
domContentLoaded29465146611455
load29665346811455
domInteractive29465146611455

@rekmarks rekmarks force-pushed the delete-public-config-store branch 3 times, most recently from ee064fd to 79ba597 Compare December 5, 2020 01:42
@rekmarks rekmarks changed the base branch from develop to web3-removal December 5, 2020 22:01
@rekmarks rekmarks force-pushed the delete-public-config-store branch from 79ba597 to a26c84c Compare December 5, 2020 22:08
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 5, 2020

Builds ready [a26c84c]
Page Load Metrics (356 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint296846168
domContentLoaded2665053558239
load2685073568239
domInteractive2665053548239

@rekmarks rekmarks changed the title Replace publicConfigStore with RPC notifications Implement breaking provider changes Dec 8, 2020
@rekmarks rekmarks changed the title Implement breaking provider changes @metamask/inpage-provider@8.0.0 Dec 8, 2020
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 8, 2020

Builds ready [851ddd1]
Page Load Metrics (532 ± 11 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45635053
domContentLoaded4905835302211
load4925845322211
domInteractive4905835302211

@MetaMask MetaMask locked and limited conversation to collaborators Dec 8, 2020
@MetaMask MetaMask unlocked this conversation Dec 8, 2020
@brad-decker
Copy link
Copy Markdown
Contributor

brad-decker commented Dec 8, 2020

@rekmarks -- can you rebase this, please?

rekmarks and others added 4 commits December 8, 2020 09:11
@rekmarks
Replace public config store with notifications
25a2afe 
* Encapsulate notification permissioning in perm controller
* Update prefix of certain internal RPC methods and notifications
* Add accounts to getProviderState
@rekmarks
@metamask/inpage-provider@8.0.0
6e4e316
@rekmarks
Send accounts with isUnlocked notification (#10007)
0755236
@rekmarks
Rename provider streams, notify provider of stream failures (#10006)
b3f61a3
@rekmarks rekmarks force-pushed the delete-public-config-store branch from 851ddd1 to b3f61a3 Compare December 8, 2020 17:11
brad-decker
brad-decker previously approved these changes Dec 8, 2020
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 8, 2020

Builds ready [b3f61a3]
Page Load Metrics (571 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint47665663
domContentLoaded3757265707234
load3767275717234
domInteractive3757265707234

brad-decker
brad-decker previously approved these changes Dec 8, 2020
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 8, 2020

Builds ready [75c957a]
Page Load Metrics (544 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45625042
domContentLoaded4886615433919
load4896635443919
domInteractive4886605433919

@rekmarks rekmarks requested a review from brad-decker December 8, 2020 19:27
@rekmarks rekmarks changed the title @metamask/inpage-provider@8.0.0 @metamask/inpage-provider@8.0.1 Dec 8, 2020
@rekmarks rekmarks changed the title @metamask/inpage-provider@8.0.1 @metamask/inpage-provider@^8.0.0 Dec 8, 2020
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 8, 2020

Builds ready [6617efe]
Page Load Metrics (602 ± 35 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48725874
domContentLoaded3697346017235
load3717356027235
domInteractive3697336017235

@rekmarks rekmarks merged commit 3bf9416 into develop Dec 8, 2020
@rekmarks rekmarks deleted the delete-public-config-store branch December 8, 2020 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@darkwing darkwing Awaiting requested review from darkwing

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

1 more reviewer

@brad-decker brad-decker brad-decker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Gudahtt Gudahtt

@brad-decker brad-decker

Labels

None yet

Projects

None yet

Milestone

v8.1.next?

Development

Successfully merging this pull request may close these issues.

5 participants

@rekmarks @metamaskbot @brad-decker @Gudahtt @danjm