Skip to content

Send accounts with isUnlocked provider notification#10007

Merged
rekmarks merged 1 commit intodelete-public-config-storefrom
accounts-with-unlock-notification
Dec 8, 2020
Merged

Send accounts with isUnlocked provider notification#10007
rekmarks merged 1 commit intodelete-public-config-storefrom
accounts-with-unlock-notification

Conversation

@rekmarks
Copy link
Copy Markdown
Member

@rekmarks rekmarks commented Dec 5, 2020 •
edited
Loading

This PR sends the accounts with the isUnlocked notification on extension unlock. To enable this, the notifyAllConnections methods on the main controller is refactored such that, when passed a function, it will for each connection call that function with the connection's origin, and use the return value as the notification payload.

Corresponding provider PR: https://github.com/MetaMask/inpage-provider/pull/121

@rekmarks rekmarks requested a review from a team as a code owner December 5, 2020 04:24
@rekmarks rekmarks requested a review from Gudahtt December 5, 2020 04:24
@rekmarks rekmarks mentioned this pull request Dec 5, 2020
Merged
@rekmarks rekmarks changed the base branch from develop to delete-public-config-store December 5, 2020 04:24
@rekmarks rekmarks force-pushed the delete-public-config-store branch from 79ba597 to a26c84c Compare December 5, 2020 22:08
@rekmarks rekmarks force-pushed the accounts-with-unlock-notification branch from d30f99d to 6cb631d Compare December 5, 2020 22:10
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 5, 2020

Builds ready [6cb631d]
Page Load Metrics (310 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint277048168
domContentLoaded2464573095527
load2484583105527
domInteractive2464573095527

@rekmarks rekmarks force-pushed the delete-public-config-store branch from a26c84c to 81618d7 Compare December 7, 2020 20:11
@rekmarks rekmarks force-pushed the accounts-with-unlock-notification branch from 6cb631d to f861ce0 Compare December 7, 2020 20:12
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 7, 2020

Builds ready [f861ce0]
Page Load Metrics (401 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint298355188
domContentLoaded2875743998340
load2895764018340
domInteractive2875743998340

NiranjanaBinoy
NiranjanaBinoy approved these changes Dec 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rekmarks rekmarks force-pushed the delete-public-config-store branch from 35b48d6 to 62e6602 Compare December 8, 2020 00:31
@rekmarks rekmarks force-pushed the accounts-with-unlock-notification branch from f861ce0 to 03caa86 Compare December 8, 2020 00:34
@rekmarks rekmarks merged this pull request into delete-public-config-store Dec 8, 2020
@rekmarks rekmarks deleted the accounts-with-unlock-notification branch December 8, 2020 00:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

1 more reviewer

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rekmarks @metamaskbot @NiranjanaBinoy @danjm