Skip to content

Initialize network controller provider chainId#9999

Merged
tmashuang merged 1 commit intodevelopfrom
initialize-provider-chainId
Dec 7, 2020
Merged

Initialize network controller provider chainId#9999
tmashuang merged 1 commit intodevelopfrom
initialize-provider-chainId

Conversation

@tmashuang
Copy link
Copy Markdown
Contributor

Initialize network controller provider chainId default networks

This primarily fixes fresh installs and rendering of contacts.

@tmashuang tmashuang requested a review from a team as a code owner December 4, 2020 02:52
@tmashuang tmashuang requested a review from brad-decker December 4, 2020 02:52
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 4, 2020

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [3a4fa4a]
Page Load Metrics (341 ± 34 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint297350168
domContentLoaded2784873397134
load2804883417134
domInteractive2784863397134

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great catch!

@tmashuang tmashuang merged commit 26272d3 into develop Dec 7, 2020
@tmashuang tmashuang deleted the initialize-provider-chainId branch December 7, 2020 19:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants