Conversation
1a993bd to
caad6fc
Compare
Member
|
This is a breaking change. I'm not sure we should include this in v8 without any notice. |
Collaborator
Builds ready [caad6fc]
Page Load Metrics (622 ± 61 ms)
|
Member
Author
|
@Gudahtt yeah, I agree. We should discuss internally and circle back. |
brad-decker
previously approved these changes
May 20, 2020
Contributor
|
approval was based on code check, missed the comments about breaking changes. |
Member
Author
|
@brad-decker no worries, we'll hold off for now! |
Contributor
|
@rekmarks I'm guessing this PR can be closed? |
Member
Author
|
@danjm this is part of the November 16 breaking changes. |
Member
Author
|
Which I will now create a label for. |
caad6fc to
ba36c2d
Compare
Collaborator
Builds ready [ba36c2d]
Page Load Metrics (504 ± 50 ms)
|
Member
Author
|
@brad-decker this is ready for review! |
brad-decker
approved these changes
Dec 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our
eth_chainIdimplementation increateInfuraClient.jsdeclared its chain ID values inline, and they were incorrectly 0-padded. This PR fixes this by using the network enums for bothnet_versionandeth_chainId.