Merged
Conversation
The `eth_decrypt` used to fail on Firefox with a recursion error. Updating these `tweetnacl` dependencies seemed to have fixed the issue the last time I tested this. When I tried to reproduce the failure today, it failed due to a different reason, both before and after this update. But nonetheless, it still seems like a good idea to update. These newer versions have no breaking changes and contain important bug fixes.
This was referenced Dec 9, 2020
Collaborator
Builds ready [a2a6efe]
Page Load Metrics (532 ± 34 ms)
|
brad-decker
approved these changes
Dec 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
eth_decryptused to fail on Firefox with a recursion error. Updating thesetweetnacldependencies seemed to have fixed the issue the last time I tested this.When I tried to reproduce the failure today, it failed due to a different reason, both before and after this update.
But nonetheless, it still seems like a good idea to update. These newer versions have no breaking changes and contain important bug fixes.