Merged
Conversation
The new metrics controller has a `trackEvent` function that was being called unbound, so `this` references were undefined. It is now bound early in both places where it is passed in as a parameter.
|
Sentry issue: METAMASK-GNZP |
Collaborator
Builds ready [8ea20f1]
Page Load Metrics (560 ± 23 ms)
|
brad-decker
approved these changes
Dec 8, 2020
Contributor
brad-decker
left a comment
There was a problem hiding this comment.
Sorry, should have tested to make sure these worked. Thanks for fixing up @Gudahtt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new metrics controller has a
trackEventfunction that was being called unbound, sothisreferences were undefined. It is now bound early in both places where it is passed in as a parameter.