Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Since v8.1.8 is replacing what v8.1.7 was previously, I cherry-picked the old v8.1.7 changelog commit and updated the version number. |
Builds ready [1b1661d]
Page Load Metrics (589 ± 31 ms)
|
|
We'll need to merge |
1b1661d to
24c8d51
Compare
This reverts commit 7696de2.
This reverts commit d783966.
* Update transaction params validation * fixup! Update transaction params validation * Update to/data error message * fixup! Update to/data error message
The `waitUntilCalled` utility now has a timeout. It will now throw an error if the stub is not called enough times, rather than blocking forever. The return type had to be changed to a function, so that we could throw when the timeout is triggered. I tried returning an error that rejected first, but if you don't handle the error synchronously Node.js will consider it to be an unhandled Promise rejected (even if it _is_ handled later on). I worked around this by resolving in the timeout case as well, so that there is never a "deferred" Promise exception in the timeout case. The returned function re-throws the error if it's given. That way there is never any unhandled Promise rejection.
Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 10.4.0 to 10.4.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md) - [Commits](highlightjs/highlight.js@10.4.0...10.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…back to build quote screen while having insufficient funds (#9994)
When the SES lockdown was added in #9729, the lockdown and the Sentry initialization were migrated from the main bundle into separate modules, which were run as separate `<script>` tags. These extra tags were accidentally omitted for `home.html` and `notification.html`. As a result Sentry was not initialized on these pages, so any errors thrown on them would not be collected. They also do not benefit from the SES lockdown. The SES lockdown and Sentry initialization modules have been added to both pages where they were missing.
The SES lockdown added in #9729 had the effect of obfuscating our error messages. Any messages printed to the console would have the error message replaced with the string "Error #" followed by a number. The stack was also updated to point at `lockdown.cjs`, though the original stack was preserved beneath the top stack frame. Marking the `console` API as untamed seems to have fixed both issues. The original error message is now printed to the console, along with the original stack.
The new metrics controller has a `trackEvent` function that was being called unbound, so `this` references were undefined. It is now bound early in both places where it is passed in as a parameter.
On older browsers that don't support `globalThis`[1], the SES lockdown throws an error. The `globalthis` shim has been added to all pages, to the background process, and to the `contentscript`. This should prevent the error on older browsers. [1]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis#Browser_compatibility
Failures to persist state are now logged in Sentry. Previously they were only logged to the background console.
When you load an extension `.zip` file in Firefox, it fails to load scripts with the `.cjs` file extension. However, it works if you load the extension via the `manifest.json` file instead. After renaming the `lockdown.cjs` file to `lockdown.js`, it works in Firefox in all cases, regardless whether it's loaded by manifest or by `.zip`.
All user-facing changes have been listed.
24c8d51 to
f579acc
Compare
|
This branch looks a little strange because I was unable to base this on |
Builds ready [f579acc]
Page Load Metrics (552 ± 14 ms)
|
There was a problem hiding this comment.
I have tested the four user-facing changes.
- #9992: Improve transaction params validation
I tested this using the malformed transaction mentioned in the repro for #9967, and I did get the appropriate error asking for either the to or data param to be set.
These two seemed fairly straightforward to test
- #9999: Fix missing contacts upon restart
I was able to confirm that contacts were viewable after restart without switching networks, so this appears to be fixed.
Additionally, I checked the console for lockdown errors on each window (popup, home, notification, phishing) and on the dapp and the background process. No errors anywhere. I also ensured Sentry was initialized everywhere it should be (in all places but the phishing page and the contentscript).
LGTM!
📦 🚀
Changelog