Update the list of post meta keys to sync for WooCommerce#8601
Merged
Update the list of post meta keys to sync for WooCommerce#8601
Conversation
…all the ones defined as used by WooCommerce and to include all the Refund related keys too.
Contributor
Author
|
This is a Bug more than an Enhancement because without the synced data we can't correctly calculate refunds. |
nabsul
reviewed
Jan 25, 2018
| private static $wc_post_meta_whitelist = array( | ||
| //woocommerce products | ||
| '_stock_status', | ||
| // https://github.com/woocommerce/woocommerce/blob/8ed6e7436ff87c2153ed30edd83c1ab8abbdd3e9/includes/data-stores/class-wc-product-data-store-cpt.php#L21 |
Contributor
There was a problem hiding this comment.
Instead of manually keeping this in sync with Jetpack_Sync_Module_WooCommerce::$internal_meta_keys, I think it would be better to use the jetpack_sync_post_meta_whitelist hook.
Contributor
Author
There was a problem hiding this comment.
I agree that this would be a good enhancement to add to WooCommerce, but I don't think it should block merging this change.
nabsul
approved these changes
Jan 25, 2018
Contributor
nabsul
left a comment
There was a problem hiding this comment.
I double checked that no pre-existing entries in the whitelist were accidentally removed. Since this is just a change to an array list, that's probably sufficient "testing" for this PR :-)
zinigor
pushed a commit
that referenced
this pull request
Jan 30, 2018
* Changelog 5.8: create base for changelog. * Update 5.8 release post link * fix 5.8 release date * Updates to plugin description * Changelog: add #8499 * Changelog: add #8506 * Changelog: add #8509 * Changelog: add #8516 * Changelog: add #8517 * Changelog: add #8523 * Changelog: add #8547 * Changelog: add #8496 * Changelog: add #8584 * Changelog: add #8595 * Changelog: add #8445 * Changelog: add #8431 * Changelog: add #8284 * Changelog: add #8270 * Changelog: add #8124 * Changelog: add #8581 * Changelog: add #8463 * Changelog: add #8568 (#8646) * Updates to testing list and changelog * Changelog: add #8443 * Changelog: add #8459 * Changelog: add #8469 * Changelog: add #8464 * Changelog: add #8478 and #8479 * Changelog: add #8483 * Changelog: add #8488 * Changelog: add #8513 * Changelog: add #8555 * Changelog: add #8565 * Changelog: add #8601 * Changelog: add #8612 * Changelog: add first pass at Search items. * Changelog: add more info to help test Search. * Changelog: add #8144 * Changelog: add #8313 * Changelog: add #8419 * Changelog: add #8465 * Changelog: add #8515 * Changelog: add #8587 * Changelog: add #8591 * Changelog: add #8659 * Changelog: add #8661 * Changelog: add #8671 * Changelog: add 5.7.1 to archived changelog too. * Reverted changes to readme, removed entry about backups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes all the ones defined as used by WooCommerce and to include all the Refund related keys too.
Related: Automattic/wp-calypso#21243 D9461-code
This also needs server side fixes to test too - D9552-code