Site Settings: Add support for the language setting to the API#8568
Merged
Site Settings: Add support for the language setting to the API#8568
Conversation
PHP 5.3 errors when trying to call `empty( SOME_CONSTANT_NAME )`. If it's set at all, just return the error.
tyxla
approved these changes
Jan 19, 2018
Member
tyxla
left a comment
There was a problem hiding this comment.
Gave this a spin in various cases (with/without constant, with/without the install_languages capability, with a custom language downloaded and specified and with the default en_US language.
Works like a charm 👍 Code also looks great! ❤️
| } | ||
|
|
||
| $value = get_option( 'WPLANG' ); | ||
| $response[ $setting ] = empty( $value ) ? 'en_US' : $value; |
Member
There was a problem hiding this comment.
According to this, we'll return en_US as a default language, but according to the definition of the setting in get_updateable_data_list(), it's be expected that it would return an empty string. Perhaps we should use the same in both locations?
Member
Author
There was a problem hiding this comment.
Explicitly set it to en_US in the declaration in 2a408ec. Thanks!
jblz
commented
Jan 20, 2018
| } | ||
|
|
||
| // `wp_download_language_pack` only tries to download packs if they're not already available | ||
| $language = wp_download_language_pack( $value ); |
Member
Author
There was a problem hiding this comment.
Todo: make sure wp_download_language_pack doesn't return false before setting the option.
Guard against `wp_download_language_pack` failure
frontdevde
added a commit
that referenced
this pull request
Jan 29, 2018
Merged
jeherve
pushed a commit
that referenced
this pull request
Jan 29, 2018
zinigor
pushed a commit
that referenced
this pull request
Jan 30, 2018
* Changelog 5.8: create base for changelog. * Update 5.8 release post link * fix 5.8 release date * Updates to plugin description * Changelog: add #8499 * Changelog: add #8506 * Changelog: add #8509 * Changelog: add #8516 * Changelog: add #8517 * Changelog: add #8523 * Changelog: add #8547 * Changelog: add #8496 * Changelog: add #8584 * Changelog: add #8595 * Changelog: add #8445 * Changelog: add #8431 * Changelog: add #8284 * Changelog: add #8270 * Changelog: add #8124 * Changelog: add #8581 * Changelog: add #8463 * Changelog: add #8568 (#8646) * Updates to testing list and changelog * Changelog: add #8443 * Changelog: add #8459 * Changelog: add #8469 * Changelog: add #8464 * Changelog: add #8478 and #8479 * Changelog: add #8483 * Changelog: add #8488 * Changelog: add #8513 * Changelog: add #8555 * Changelog: add #8565 * Changelog: add #8601 * Changelog: add #8612 * Changelog: add first pass at Search items. * Changelog: add more info to help test Search. * Changelog: add #8144 * Changelog: add #8313 * Changelog: add #8419 * Changelog: add #8465 * Changelog: add #8515 * Changelog: add #8587 * Changelog: add #8591 * Changelog: add #8659 * Changelog: add #8661 * Changelog: add #8671 * Changelog: add 5.7.1 to archived changelog too. * Reverted changes to readme, removed entry about backups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide API support for users to manage site / blog language from their WordPress.com Site Settings page.
See: Automattic/wp-calypso#11316
Changes proposed in this Pull Request:
lang_idWPLANGoptionTesting instructions:
Proposed changelog entry for your changes:
Added support for changing site language via WordPress.com