JSON API: Remove obsolete code to query invites directly from a JP site#8515
Merged
JSON API: Remove obsolete code to query invites directly from a JP site#8515
Conversation
All invite data has been stored on WP.com for some time now.
nylen
commented
Jan 22, 2018
| if ( ! is_multisite() ) { | ||
| return new WP_Error( 'forbidden', 'To query invites, site must be on a multisite installation.', 403 ); | ||
| if ( ! defined( 'IS_WPCOM' ) || ! IS_WPCOM ) { | ||
| return new WP_Error( 'not_implemented', 'Querying WP.com endpoint data from a Jetpack site is not implemented.', 400 ); |
Contributor
Author
There was a problem hiding this comment.
This should say "invite" instead of "endpoint".
Contributor
|
@nylen Apologies for the slow reply. I've added a task to review this tomorrow. |
Contributor
Author
|
No worries. After thinking about this some more, I think we should remove this endpoint from Jetpack entirely and moving it to WPCOM-only. If I am understanding the situation correctly, it hasn't been able to do anything for a good while. |
ebinnion
approved these changes
Jan 24, 2018
Contributor
I agree, especially since we're having to add |
Contributor
Author
|
We could also remove this one: https://github.com/Automattic/jetpack/blob/master/json-endpoints/class.wpcom-json-api-update-invites-endpoint.php However, there's not as much of a reason to do it, because as far as I can tell, we don't need to make any changes to that endpoint to support new invite features. |
zinigor
approved these changes
Jan 30, 2018
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Looks great! Thank you :)
zinigor
pushed a commit
that referenced
this pull request
Jan 30, 2018
* Changelog 5.8: create base for changelog. * Update 5.8 release post link * fix 5.8 release date * Updates to plugin description * Changelog: add #8499 * Changelog: add #8506 * Changelog: add #8509 * Changelog: add #8516 * Changelog: add #8517 * Changelog: add #8523 * Changelog: add #8547 * Changelog: add #8496 * Changelog: add #8584 * Changelog: add #8595 * Changelog: add #8445 * Changelog: add #8431 * Changelog: add #8284 * Changelog: add #8270 * Changelog: add #8124 * Changelog: add #8581 * Changelog: add #8463 * Changelog: add #8568 (#8646) * Updates to testing list and changelog * Changelog: add #8443 * Changelog: add #8459 * Changelog: add #8469 * Changelog: add #8464 * Changelog: add #8478 and #8479 * Changelog: add #8483 * Changelog: add #8488 * Changelog: add #8513 * Changelog: add #8555 * Changelog: add #8565 * Changelog: add #8601 * Changelog: add #8612 * Changelog: add first pass at Search items. * Changelog: add more info to help test Search. * Changelog: add #8144 * Changelog: add #8313 * Changelog: add #8419 * Changelog: add #8465 * Changelog: add #8515 * Changelog: add #8587 * Changelog: add #8591 * Changelog: add #8659 * Changelog: add #8661 * Changelog: add #8671 * Changelog: add 5.7.1 to archived changelog too. * Reverted changes to readme, removed entry about backups.
nylen
added a commit
that referenced
this pull request
Feb 23, 2018
This endpoint does not work with the current implementation of invites management. All invite data is stored on the WP.com server and manipulated via WP.com-only API endpoints, so we can remove this code from Jetpack. Follow-up to #8515.
dereksmart
pushed a commit
that referenced
this pull request
Feb 26, 2018
This endpoint does not work with the current implementation of invites management. All invite data is stored on the WP.com server and manipulated via WP.com-only API endpoints, so we can remove this code from Jetpack. Follow-up to #8515.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All invite data has been stored on WP.com for some time now. This PR assumes this is true for multisite Jetpack installations as well, which appears to be the case because I can't find any Jetpack code that calls this endpoint.
If this is indeed the case, then we can simplify this endpoint pretty dramatically (short of a full removal of the endpoint from Jetpack, which would be another option).