Skip to content

Fix/activity log plugins theme edit#8459

Merged
enejb merged 2 commits intomasterfrom
fix/activity-log-plugins-theme-edit
Jan 4, 2018
Merged

Fix/activity log plugins theme edit#8459
enejb merged 2 commits intomasterfrom
fix/activity-log-plugins-theme-edit

Conversation

@enejb
Copy link
Copy Markdown
Member

@enejb enejb commented Jan 4, 2018

Fixes bug where when user is running WP 4.9 and up doesn't see editing of themes and plugins in the activity log.

Changes proposed in this Pull Request:

  • Start listening for the ajax actions that updates themes and plugin in WP 4.9 do the updating of files use the same checking for errors expect the one that actually checks if the fatals occur.

This would be easier if core had a seperate do_action when things were successful.

Testing instructions:

Edit a theme or a plugin and notice that the right info show up in the activity log.

enejb added 2 commits January 3, 2018 20:36
The activity log lost the ability to record plugin eding for WP version 4.9.
@enejb enejb self-assigned this Jan 4, 2018
@enejb enejb requested review from gititon and roccotripaldi January 4, 2018 04:43
@enejb enejb requested a review from a team as a code owner January 4, 2018 04:43
@enejb enejb added [Feature] Activity Log [Status] Needs Review This PR is ready for review. Bug When a feature is broken and / or not performing as intended labels Jan 4, 2018
Copy link
Copy Markdown
Contributor

@eliorivero eliorivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine! 🐑

Tested this on my site elio.blog without this PR and editing a theme and a plugin and events weren't showing in AL.

Switched to this PR and edited theme/plugin plugin and this time they show up in AL.

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 4, 2018
@enejb enejb merged commit 251dd90 into master Jan 4, 2018
@dereksmart dereksmart deleted the fix/activity-log-plugins-theme-edit branch January 4, 2018 17:17
@oskosk oskosk added this to the 5.8 milestone Jan 8, 2018
jeherve added a commit that referenced this pull request Jan 29, 2018
zinigor pushed a commit that referenced this pull request Jan 30, 2018
* Changelog 5.8: create base for changelog.

* Update 5.8 release post link

* fix 5.8 release date

* Updates to plugin description

* Changelog: add #8499

* Changelog: add #8506

* Changelog: add #8509

* Changelog: add #8516

* Changelog: add #8517

* Changelog: add #8523

* Changelog: add #8547

* Changelog: add #8496

* Changelog: add #8584

* Changelog: add #8595

* Changelog: add #8445

* Changelog: add #8431

* Changelog: add #8284

* Changelog: add #8270

* Changelog: add #8124

* Changelog: add #8581

* Changelog: add #8463

* Changelog: add #8568 (#8646)

* Updates to testing list and changelog

* Changelog: add #8443

* Changelog: add #8459

* Changelog: add #8469

* Changelog: add #8464

* Changelog: add #8478 and #8479

* Changelog: add #8483

* Changelog: add #8488

* Changelog: add #8513

* Changelog: add #8555

* Changelog: add #8565

* Changelog: add #8601

* Changelog: add #8612

* Changelog: add first pass at Search items.

* Changelog: add more info to help test Search.

* Changelog: add #8144

* Changelog: add #8313

* Changelog: add #8419

* Changelog: add #8465

* Changelog: add #8515

* Changelog: add #8587

* Changelog: add #8591

* Changelog: add #8659

* Changelog: add #8661

* Changelog: add #8671

* Changelog: add 5.7.1 to archived changelog too.

* Reverted changes to readme, removed entry about backups.
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Activity Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants