Masterbar: Fix compatibility with BeaverBuilder plugin.#8595
Merged
jeherve merged 3 commits intoAutomattic:masterfrom Jan 25, 2018
Merged
Masterbar: Fix compatibility with BeaverBuilder plugin.#8595jeherve merged 3 commits intoAutomattic:masterfrom
jeherve merged 3 commits intoAutomattic:masterfrom
Conversation
added 2 commits
January 23, 2018 15:15
When beaverBuilder publishes a layout the admin bar is restored but unclickable. The filter `fl_builder_should_refresh_on_publish` forces BeaverBuilder to refresh the current page.
jeherve
requested changes
Jan 23, 2018
Member
jeherve
left a comment
There was a problem hiding this comment.
This is looking good. I would only have one small nitpick with the function name, just so we know what this is all about when we get back to it later.
3rd-party/beaverbuilder.php
Outdated
| /** | ||
| * If masterbar module is active force BeaverBuilder to refresh when publishing a layout. | ||
| */ | ||
| function masterbar_refresh() { |
Member
There was a problem hiding this comment.
Do you think you could name this a bit differently, since we are refreshing the builder, and not the masterbar?
Author
|
Not sure why travis failed, just seemed to timeout. |
Member
|
Thanks. I just relaunched the Travis tests to get that solved. |
jeherve
approved these changes
Jan 25, 2018
zinigor
pushed a commit
that referenced
this pull request
Jan 30, 2018
* Changelog 5.8: create base for changelog. * Update 5.8 release post link * fix 5.8 release date * Updates to plugin description * Changelog: add #8499 * Changelog: add #8506 * Changelog: add #8509 * Changelog: add #8516 * Changelog: add #8517 * Changelog: add #8523 * Changelog: add #8547 * Changelog: add #8496 * Changelog: add #8584 * Changelog: add #8595 * Changelog: add #8445 * Changelog: add #8431 * Changelog: add #8284 * Changelog: add #8270 * Changelog: add #8124 * Changelog: add #8581 * Changelog: add #8463 * Changelog: add #8568 (#8646) * Updates to testing list and changelog * Changelog: add #8443 * Changelog: add #8459 * Changelog: add #8469 * Changelog: add #8464 * Changelog: add #8478 and #8479 * Changelog: add #8483 * Changelog: add #8488 * Changelog: add #8513 * Changelog: add #8555 * Changelog: add #8565 * Changelog: add #8601 * Changelog: add #8612 * Changelog: add first pass at Search items. * Changelog: add more info to help test Search. * Changelog: add #8144 * Changelog: add #8313 * Changelog: add #8419 * Changelog: add #8465 * Changelog: add #8515 * Changelog: add #8587 * Changelog: add #8591 * Changelog: add #8659 * Changelog: add #8661 * Changelog: add #8671 * Changelog: add 5.7.1 to archived changelog too. * Reverted changes to readme, removed entry about backups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8594
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: