Bring disconnected landing page in line with new site content#8565
Bring disconnected landing page in line with new site content#8565
Conversation
jeherve
left a comment
There was a problem hiding this comment.
A few comments about i18n and wording
|
|
||
| <div className="jp-jetpack-connect__feature-list"> | ||
| <div className="jp-jetpack-connect__feature-list-column"> | ||
| <h3 title="Jetpack's WordPress themes" className="dops-section-header__label"> |
There was a problem hiding this comment.
Shouldn't we make those titles translatable as well?
| <div className="jp-jetpack-connect__feature-list-column"> | ||
| <h3 title="Jetpack's Sharing and Like features" className="dops-section-header__label"> | ||
| { __( 'Sharing & Like Buttons' ) } | ||
| <h3 title="Jetpack's publicize features" className="dops-section-header__label"> |
There was a problem hiding this comment.
Should we capitalize Publicize?
| { __( | ||
| 'Jetpack blocks malicious log in attempts, lets you know if your site goes down, ' + | ||
| 'and can automatically update your plugins, so you don’t have to worry.' | ||
| 'Automatic defense against hacks, malware, spam, data loss, and downtime.' |
| <div className="jp-jetpack-connect__feature-list-column"> | ||
| <h3 title="Jetpack's Protect feature" className="dops-section-header__label"> | ||
| { __( 'Protect', { context: 'Header. Noun: Protect is a module of Jetpack.' } ) } | ||
| <h3 title="Jetpack's monitor feature" className="dops-section-header__label"> |
There was a problem hiding this comment.
Should we capitalize Monitor here?
|
@richardmuscat looks good for a quick fix. BUT I think we should put on our list to update this page to reflect the design of the new jetpack.com homepage—or something a little more simple than the product tour page.
Here's a mock that @joanrho did for the full screen connection prompt on the /plugins/ page. Would be great to have something similar. cc @rickybanister |
|
Just to add to what @jeffgolenski said, we would implement the same content for the disconnected landing page as we would for the plugins splash page. Same code, same content. Less to maintain. @johnHackworth's team may be able to work on that for the next release. I think it's fine to merge this PR for the next release, but it may be updated for the next one. |
|
@jeherve I have addressed your comments, can you please take a look again? |
jeherve
left a comment
There was a problem hiding this comment.
Looking good now. Merging this.
* Changelog 5.8: create base for changelog. * Update 5.8 release post link * fix 5.8 release date * Updates to plugin description * Changelog: add #8499 * Changelog: add #8506 * Changelog: add #8509 * Changelog: add #8516 * Changelog: add #8517 * Changelog: add #8523 * Changelog: add #8547 * Changelog: add #8496 * Changelog: add #8584 * Changelog: add #8595 * Changelog: add #8445 * Changelog: add #8431 * Changelog: add #8284 * Changelog: add #8270 * Changelog: add #8124 * Changelog: add #8581 * Changelog: add #8463 * Changelog: add #8568 (#8646) * Updates to testing list and changelog * Changelog: add #8443 * Changelog: add #8459 * Changelog: add #8469 * Changelog: add #8464 * Changelog: add #8478 and #8479 * Changelog: add #8483 * Changelog: add #8488 * Changelog: add #8513 * Changelog: add #8555 * Changelog: add #8565 * Changelog: add #8601 * Changelog: add #8612 * Changelog: add first pass at Search items. * Changelog: add more info to help test Search. * Changelog: add #8144 * Changelog: add #8313 * Changelog: add #8419 * Changelog: add #8465 * Changelog: add #8515 * Changelog: add #8587 * Changelog: add #8591 * Changelog: add #8659 * Changelog: add #8661 * Changelog: add #8671 * Changelog: add 5.7.1 to archived changelog too. * Reverted changes to readme, removed entry about backups.
Changes proposed in this Pull Request:
Testing instructions: