Conversation
zinigor
approved these changes
Jan 23, 2018
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Code looks fine, settings work fine as well, but for me when toggling the second ad below the post, they are shown in the same spot. Attaching the screenshot below.
Contributor
|
|
Member
Author
|
Thanks for taking a look @zinigor, the double ad is as-intended. Once your site gets cleared in the back-end it'll eventually two different ads. There might be a few more tweaks we need to make, I'll ping you if we end up needing another review. |
08bb351 to
8cae65f
Compare
rclachance
approved these changes
Jan 23, 2018
zinigor
reviewed
Jan 29, 2018
| add_filter( 'the_excerpt', array( $this, 'insert_ad' ) ); | ||
|
|
||
| if ( $this->option( 'enable_header_ad' ) ) { | ||
| if ( ! apply_filters( 'wordads_content_disable', false ) ) { |
Contributor
There was a problem hiding this comment.
One more nitpick - can you please add filter headers here? Here is an example of a comment block that will be picked up by the parser: https://github.com/Automattic/jetpack/blob/master/class.jetpack.php#L1552
Notably: 1. Default header unit to on 2. Increment widget unit section ids so they’re unique 3. Ensure belowpost unit(s) only gets displayed once per page Check for non-main calls that might trigger the hooks $belowpost_loaded is too problematic, adding filters to allow ad hoc disabling
e690357 to
073339d
Compare
Member
Author
|
No problem @zinigor, added. |
jeherve
approved these changes
Jan 30, 2018
Member
jeherve
left a comment
There was a problem hiding this comment.
Seems to work for me too. Will merge when the tests complete.
zinigor
pushed a commit
that referenced
this pull request
Jan 30, 2018
* Changelog 5.8: create base for changelog. * Update 5.8 release post link * fix 5.8 release date * Updates to plugin description * Changelog: add #8499 * Changelog: add #8506 * Changelog: add #8509 * Changelog: add #8516 * Changelog: add #8517 * Changelog: add #8523 * Changelog: add #8547 * Changelog: add #8496 * Changelog: add #8584 * Changelog: add #8595 * Changelog: add #8445 * Changelog: add #8431 * Changelog: add #8284 * Changelog: add #8270 * Changelog: add #8124 * Changelog: add #8581 * Changelog: add #8463 * Changelog: add #8568 (#8646) * Updates to testing list and changelog * Changelog: add #8443 * Changelog: add #8459 * Changelog: add #8469 * Changelog: add #8464 * Changelog: add #8478 and #8479 * Changelog: add #8483 * Changelog: add #8488 * Changelog: add #8513 * Changelog: add #8555 * Changelog: add #8565 * Changelog: add #8601 * Changelog: add #8612 * Changelog: add first pass at Search items. * Changelog: add more info to help test Search. * Changelog: add #8144 * Changelog: add #8313 * Changelog: add #8419 * Changelog: add #8465 * Changelog: add #8515 * Changelog: add #8587 * Changelog: add #8591 * Changelog: add #8659 * Changelog: add #8661 * Changelog: add #8671 * Changelog: add 5.7.1 to archived changelog too. * Reverted changes to readme, removed entry about backups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of small updates to bring Jetpack Ads on par w/ .com.
Notably:
To Test
Display second ad below postAppearance -> Widgets, check both load.