Skip to content

Custom CSS: add CSS Grid Layout support.#8445

Merged
oskosk merged 1 commit intomasterfrom
update/customcss-whitelist-grid-layout
Jan 5, 2018
Merged

Custom CSS: add CSS Grid Layout support.#8445
oskosk merged 1 commit intomasterfrom
update/customcss-whitelist-grid-layout

Conversation

@danielwrobert
Copy link
Copy Markdown
Contributor

@danielwrobert danielwrobert commented Jan 3, 2018

Fixes #8394

Summary:

This PR adds all current properties for the CSS Grid Layout Module Level 1 specification to the Custom CSS whitelist.

Test Plan:

It does not appear that the Custom CSS module is used on self-hosted sites - this is mainly a PR for support requests on WPCOM.

Add all current properties for the CSS Grid Layout Module Level 1
specification to Custom CSS whitelist.
@danielwrobert danielwrobert added [Feature] Custom CSS Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Jan 3, 2018
@danielwrobert danielwrobert self-assigned this Jan 3, 2018
@jeherve jeherve added the [Status] Needs Review This PR is ready for review. label Jan 3, 2018
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Jan 3, 2018

It does not appear that the Custom CSS module is used on self-hosted sites

The module can still be used on self-hosted sites, so it's not a useless change. 👍

@jeherve
Copy link
Copy Markdown
Member

jeherve commented Jan 3, 2018

Fixes #8394

Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 3, 2018
Copy link
Copy Markdown
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk merged commit d709f31 into master Jan 5, 2018
@jeherve jeherve deleted the update/customcss-whitelist-grid-layout branch January 5, 2018 21:10
@oskosk oskosk added this to the 5.8 milestone Jan 8, 2018
@georgestephanis
Copy link
Copy Markdown
Contributor

@danielwrobert Is this live on WPCOM currently?

@danielwrobert
Copy link
Copy Markdown
Contributor Author

@georgestephanis No, not yet - I had it on my list to add today though.

jeherve added a commit that referenced this pull request Jan 25, 2018
zinigor pushed a commit that referenced this pull request Jan 30, 2018
* Changelog 5.8: create base for changelog.

* Update 5.8 release post link

* fix 5.8 release date

* Updates to plugin description

* Changelog: add #8499

* Changelog: add #8506

* Changelog: add #8509

* Changelog: add #8516

* Changelog: add #8517

* Changelog: add #8523

* Changelog: add #8547

* Changelog: add #8496

* Changelog: add #8584

* Changelog: add #8595

* Changelog: add #8445

* Changelog: add #8431

* Changelog: add #8284

* Changelog: add #8270

* Changelog: add #8124

* Changelog: add #8581

* Changelog: add #8463

* Changelog: add #8568 (#8646)

* Updates to testing list and changelog

* Changelog: add #8443

* Changelog: add #8459

* Changelog: add #8469

* Changelog: add #8464

* Changelog: add #8478 and #8479

* Changelog: add #8483

* Changelog: add #8488

* Changelog: add #8513

* Changelog: add #8555

* Changelog: add #8565

* Changelog: add #8601

* Changelog: add #8612

* Changelog: add first pass at Search items.

* Changelog: add more info to help test Search.

* Changelog: add #8144

* Changelog: add #8313

* Changelog: add #8419

* Changelog: add #8465

* Changelog: add #8515

* Changelog: add #8587

* Changelog: add #8591

* Changelog: add #8659

* Changelog: add #8661

* Changelog: add #8671

* Changelog: add 5.7.1 to archived changelog too.

* Reverted changes to readme, removed entry about backups.
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Custom CSS Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom CSS: CSS Grid attributes and units removed on save

6 participants