Fix lazy images issue with Gazette theme#8499
Merged
gravityrail merged 3 commits intomasterfrom Jan 23, 2018
Merged
Conversation
Viper007Bond
suggested changes
Jan 11, 2018
modules/lazy-images/lazy-images.php
Outdated
| } | ||
|
|
||
| // check for gazette featured images, which are incompatible | ||
| if ( isset( $attributes['class'] ) && strpos( $attributes['class'], 'gazette-featured-content-thumbnail' ) > 0 ) { |
Contributor
There was a problem hiding this comment.
You should use false !== strpos() instead to avoid the situation where gazette-featured-content-thumbnail is the first thing in the string.
Contributor
Author
There was a problem hiding this comment.
Good catch!! Fixed.
Viper007Bond
approved these changes
Jan 22, 2018
zinigor
pushed a commit
that referenced
this pull request
Jan 30, 2018
* Changelog 5.8: create base for changelog. * Update 5.8 release post link * fix 5.8 release date * Updates to plugin description * Changelog: add #8499 * Changelog: add #8506 * Changelog: add #8509 * Changelog: add #8516 * Changelog: add #8517 * Changelog: add #8523 * Changelog: add #8547 * Changelog: add #8496 * Changelog: add #8584 * Changelog: add #8595 * Changelog: add #8445 * Changelog: add #8431 * Changelog: add #8284 * Changelog: add #8270 * Changelog: add #8124 * Changelog: add #8581 * Changelog: add #8463 * Changelog: add #8568 (#8646) * Updates to testing list and changelog * Changelog: add #8443 * Changelog: add #8459 * Changelog: add #8469 * Changelog: add #8464 * Changelog: add #8478 and #8479 * Changelog: add #8483 * Changelog: add #8488 * Changelog: add #8513 * Changelog: add #8555 * Changelog: add #8565 * Changelog: add #8601 * Changelog: add #8612 * Changelog: add first pass at Search items. * Changelog: add more info to help test Search. * Changelog: add #8144 * Changelog: add #8313 * Changelog: add #8419 * Changelog: add #8465 * Changelog: add #8515 * Changelog: add #8587 * Changelog: add #8591 * Changelog: add #8659 * Changelog: add #8661 * Changelog: add #8671 * Changelog: add 5.7.1 to archived changelog too. * Reverted changes to readme, removed entry about backups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes blank featured images in top area of Gazette theme when Lazy Images is switched on.
https://wordpress.org/support/topic/no-header-images-with-jetpack-lazy-images/#post-9849480
The issue is that Gazette rendered out the original image, then in javascript they copy the image
srcattribute and put it in thestyleattribute of the parent tag asbackground-image: url( 'the-original-image' ), then hide the original image tag - which in the case of lazy images means they are essentially copying the placeholder into the parent where we can't modify it.This PR is my attempt at the simplest, narrowest solution targeting this theme. Open to better suggestions!
Testing instructions:
To see the issue:
To test this patch:
Proposed changelog entry for your changes: