Skip to content

OpenTable Block: fix possible warning when rid key is not defined#15133

Merged
brbrr merged 4 commits intomasterfrom
fix/opentable-15129
Mar 30, 2020
Merged

OpenTable Block: fix possible warning when rid key is not defined#15133
brbrr merged 4 commits intomasterfrom
fix/opentable-15129

Conversation

@brbrr
Copy link
Copy Markdown
Contributor

@brbrr brbrr commented Mar 26, 2020

Fixes #15129

Changes proposed in this Pull Request:

  • Fix possible notice and warning that is thrown when OpenTable block published unconfigured

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • bug fix

Testing instructions:

  • Start with connected Jetpack
  • Add unconfigured OpenTable block, and publish the post
  • Visit the post frontend. Make sure no errors or warnings were thrown in the error log

Proposed changelog entry for your changes:

  • fix a warning thrown for empty OpenTable block

@brbrr brbrr added Bug When a feature is broken and / or not performing as intended Unit Tests [Block] OpenTable labels Mar 26, 2020
@brbrr brbrr added this to the 8.4 milestone Mar 26, 2020
@brbrr brbrr requested a review from a team March 26, 2020 11:46
@brbrr brbrr self-assigned this Mar 26, 2020
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Mar 26, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello brbrr! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40899-code before merging this PR. Thank you!

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Mar 26, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 2513b69

@brbrr brbrr added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Mar 26, 2020
jeherve
jeherve approved these changes Mar 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, and with tests even! Thank you!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 27, 2020
@brbrr brbrr merged commit ad6a639 into master Mar 30, 2020
@brbrr brbrr deleted the fix/opentable-15129 branch March 30, 2020 13:06
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 30, 2020
@brbrr
Copy link
Copy Markdown
Contributor Author

brbrr commented Mar 30, 2020

r205040-wpcom

jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
Changelog: add #15133
6cdd6ce
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@brbrr brbrr

Labels

[Block] OpenTable Bug When a feature is broken and / or not performing as intended Touches WP.com Files Unit Tests

Projects

None yet

Milestone

8.4

Development

Successfully merging this pull request may close these issues.

OpenTable Block: Notice and Warning when empty block is published

4 participants

@brbrr @matticbot @jetpackbot @jeherve