Skip to content

Update keywords for blocks#14842

Merged
scruffian merged 3 commits intomasterfrom
update/block-keywords
Mar 5, 2020
Merged

Update keywords for blocks#14842
scruffian merged 3 commits intomasterfrom
update/block-keywords

Conversation

@scruffian
Copy link
Copy Markdown
Member

@scruffian scruffian commented Feb 28, 2020

Some of the comments on the CfT for Google Calendar and Revue mentioned about our keyword use, so I reviewed every block and made a few changes to make our keywords more consistent.

Changes proposed in this Pull Request:

  • Added keywords where there were none.
  • Added additional keywords (up to 3) when there were more relevant ones
  • Removed pointless keywords, so that we only have 3 per block
  • Used _x for all keywords for consistency

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Changes to blocks

Testing instructions:

  • Try searching for blocks in the inserter using the relevant keywords and ensure they show

Proposed changelog entry for your changes:

  • no changelog

@scruffian scruffian added [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Eventbrite [Block] OpenTable [Block] Calendly [Block] Google Calendar labels Feb 28, 2020
@scruffian scruffian requested review from a team February 28, 2020 11:13
@scruffian scruffian self-assigned this Feb 28, 2020
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Feb 28, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D39595-code before merging this PR. Thank you!

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Feb 28, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 4d8005d

apeatling
apeatling previously approved these changes Feb 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm assuming "Map" as a search term was removed from the the map block because it matches on the block name already?

@simison
Copy link
Copy Markdown
Member

simison commented Mar 1, 2020

The 3 keywords limit might've been removed. Wanna test and confirm? :-)

@scruffian
Copy link
Copy Markdown
Member Author

scruffian commented Mar 2, 2020 •
edited
Loading

Looks good. I'm assuming "Map" as a search term was removed from the the map block because it matches on the block name already?

Yep! Also, we have maps as a keyword, so map would match that too!

@scruffian
Copy link
Copy Markdown
Member Author

scruffian commented Mar 2, 2020

The 3 keywords limit might've been removed. Wanna test and confirm? :-)

You're right, I'll add some more!

@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Mar 2, 2020

scruffian, Your synced wpcom patch D39595-code has been updated.

apeatling
apeatling reviewed Mar 2, 2020
View reviewed changes
extensions/blocks/simple-payments/index.js
_x( 'purchase', 'block search term', 'jetpack' ),
_x( 'sell', 'block search term', 'jetpack' ),
_x( 'shop', 'block search term', 'jetpack' ),
'PayPal',
Copy link
Copy Markdown
Contributor

@apeatling apeatling Mar 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "product"? There is products in the description, but not singular.

@apeatling apeatling self-requested a review March 2, 2020 22:22
apeatling
apeatling previously approved these changes Mar 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my suggestion above, this looks good. I rechecked call for testing posts and all suggestions were added. 👍

Copons
Copons reviewed Mar 3, 2020
View reviewed changes
extensions/blocks/revue/index.js
_x( 'email', 'block search term', 'jetpack' ),
_x( 'subscription', 'block search term', 'jetpack' ),
_x( 'newsletter', 'block search term', 'jetpack' ),
],
Copy link
Copy Markdown
Contributor

@Copons Copons Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about also mailing list?
Might be redundant if the autocomplete matches mail with email anyway. 🤔

Copy link
Copy Markdown
Member Author

@scruffian scruffian Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

Copons
Copons reviewed Mar 3, 2020
View reviewed changes
extensions/blocks/wordads/index.js Outdated
keywords: [
_x( 'ads', 'block search term', 'jetpack' ),
'WordAds',
_x( 'Advertisement', 'block search term', 'jetpack' ),
Copy link
Copy Markdown
Contributor

@Copons Copons Mar 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extreme nitpick ahead: is this the only capitalized keyword? 😄

jeherve
jeherve reviewed Mar 4, 2020
View reviewed changes
@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Mar 4, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 4, 2020
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Mar 4, 2020

scruffian, Your synced wpcom patch D39595-code has been updated.

@scruffian
Copy link
Copy Markdown
Member Author

scruffian commented Mar 4, 2020

This is ready for another review.

@scruffian scruffian added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 4, 2020
@apeatling apeatling self-requested a review March 4, 2020 15:25
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 5, 2020
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Mar 5, 2020

scruffian, Your synced wpcom patch D39595-code has been updated.

@scruffian scruffian merged commit 04bfea9 into master Mar 5, 2020
@scruffian scruffian deleted the update/block-keywords branch March 5, 2020 16:40
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 5, 2020
@scruffian
Copy link
Copy Markdown
Member Author

scruffian commented Mar 5, 2020

r203912-wpcom

jeherve added a commit that referenced this pull request Mar 20, 2020
@jeherve
Changelog: add #14842
0f38a8a
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

@Copons Copons Copons approved these changes

+1 more reviewer

@apeatling apeatling apeatling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@scruffian scruffian

Labels

[Block] Calendly [Block] Eventbrite [Block] Google Calendar [Block] Map [Block] OpenTable [Block] Pinterest [Block] Revue [Feature] Related Posts [Feature] WordAds [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files

Projects

None yet

Milestone

8.4

Development

Successfully merging this pull request may close these issues.

8 participants

@scruffian @matticbot @jetpackbot @simison @jeherve @apeatling @Copons @creativecoder