Debug tests: adds sync health card, and allows test to be hidden on site health page#14897
Debug tests: adds sync health card, and allows test to be hidden on site health page#14897roccotripaldi merged 2 commits intomasterfrom
Conversation
This is an automated check which relies on |
keoshi
left a comment
There was a problem hiding this comment.
Looks great to me, Rocco! 🚀
mdbitz
left a comment
There was a problem hiding this comment.
Pending removal of the local debug statement. and confirmation of link endpoint.
| $name, | ||
| __( 'Jetpack Sync has been disabled on your site.', 'jetpack' ), | ||
| 'enable_sync', | ||
| admin_url( '#' ), |
There was a problem hiding this comment.
Are we sure we want to land on the Admin page in this case. It might be worth checking if we have a end user visible guide on Sync, how to enable, or etc?
There was a problem hiding this comment.
that's an outstanding question. i have no idea where to send people for this.
There was a problem hiding this comment.
@roccotripaldi You mentioned there being a filter to turn off sync. Is this documented anywhere in our support pages? If so, we should link it there. If not, maybe JPOP Happy can create a document for it?
dd2f1f6 to
9ada076
Compare
|
Since there is currently no public facing place that talks about Sync settings, i've updated the card to read:
The action links to our github repo: I think we should merge it! There's plenty of time this month before release if we can get up a public facing sync page. |
ea3a66c to
00dc7c0
Compare
Debug tests - allow skipped tests to be ommited from the Site Health page - add a test for Sync health Debug tests: adding a short description for enabling sync Debug: add a short description for the connection failure test Debug: sync health test Since there's not currently any public facing docs on Sync settings let's link the action to Github.
00dc7c0 to
8a09d2d
Compare
|
This is rebased, and ready to go in my opion. |
mdbitz
left a comment
There was a problem hiding this comment.
Approved, Verified shows message when sync is disabled.
* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description
Fixes n/a
Changes proposed in this Pull Request:
On the site health page, if sync is disabled, let's show a recommended improvement:
This PR also refactors debug tests to allow a test to be hidden on the site health page. For example, current a skipped test will still appear on the Site Health page as being successfully passed. For sync health, there are some cases where we don't want to show it at all.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Proposed changelog entry for your changes: