Skip to content

Allow caching script in Facebook embeds and Facebook Page Plugin widget#14798

Merged
jeherve merged 1 commit intomasterfrom
update/facebook-embed-script
Mar 17, 2020
Merged

Allow caching script in Facebook embeds and Facebook Page Plugin widget#14798
jeherve merged 1 commit intomasterfrom
update/facebook-embed-script

Conversation

@kienstra
Copy link
Copy Markdown
Contributor

@kienstra kienstra commented Feb 25, 2020 •
edited
Loading

Changes proposed in this Pull Request

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Not a new feature, only a performance enhancement to a given feature. No intended change in functionality.

Testing instructions:

  • In the Customizer, add a 'Facebook Page Plugin' widget
  • Enter a 'Facebook Page URL,' like https://www.facebook.com/cureintl/
  • Click 'Publish,' and view the front-end
  • Expected: the widget still looks and works as expected
  • Also test Facebook embeds, using a 'Facebook' or 'Embed' block

Proposed changelog entry for your changes:

  • Facebook embed and Facebook Page Plugin performance enhancement

@kienstra
In Facebook embeds and Page Plugin widget, allow caching script
93fa1f8 
Instead of jQuery.getScript(),
use vanilla JS to get the script.
This should allow the browser to cache it.
@kienstra kienstra requested a review from a team February 25, 2020 18:32
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Feb 25, 2020

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 93fa1f8

@kienstra kienstra added the [Status] Needs Review This PR is ready for review. label Feb 25, 2020
@jeherve jeherve added [Focus] Performance Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets labels Feb 25, 2020
@jeherve jeherve added this to the 8.4 milestone Feb 25, 2020
@kienstra
Copy link
Copy Markdown
Contributor Author

kienstra commented Feb 27, 2020

Hi @dero, could you please review this? Thanks, and have a great day.

@dero
Copy link
Copy Markdown
Contributor

dero commented Feb 27, 2020

@kienstra This looks good!

@kienstra
Copy link
Copy Markdown
Contributor Author

kienstra commented Feb 27, 2020

Thanks, Dero!

@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Mar 6, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello kienstra! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40013-code before merging this PR. Thank you!

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 6, 2020
@jeherve jeherve merged commit 4ecf55a into master Mar 17, 2020
@jeherve jeherve deleted the update/facebook-embed-script branch March 17, 2020 11:40
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 17, 2020
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Mar 17, 2020

r204382-wpcom

jeherve added a commit that referenced this pull request Mar 20, 2020
@jeherve
Changelog: add #14798
03a0a40
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

+1 more reviewer

@dero dero dero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kienstra kienstra

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Focus] Performance Touches WP.com Files

Projects

None yet

Milestone

8.4

Development

Successfully merging this pull request may close these issues.

6 participants

@kienstra @jetpackbot @dero @matticbot @jeherve @kraftbj