Skip to content

WordAds: Update loader snippets#14990

Merged
jeherve merged 1 commit intomasterfrom
update/wordads-ipw-loader
Mar 26, 2020
Merged

WordAds: Update loader snippets#14990
jeherve merged 1 commit intomasterfrom
update/wordads-ipw-loader

Conversation

@dbspringer
Copy link
Copy Markdown
Member

@dbspringer dbspringer commented Mar 13, 2020

Update js IPW loader snippets to support https://www.chromestatus.com/feature/6251880185331712

Changes proposed in this Pull Request:

  • Update to the ad loader scripts

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Request here: p5UegX-xy-p2

Testing instructions:

  1. Enable Jetpack Ads module on your test site (requires Premium sub).
  2. View page with ads, check console has no errors (ads should continue loading as usual).

Proposed changelog entry for your changes:

@dbspringer dbspringer requested a review from a team March 13, 2020 19:46
@dbspringer dbspringer self-assigned this Mar 13, 2020
@dbspringer dbspringer added this to the 8.4 milestone Mar 13, 2020
@dbspringer dbspringer added the [Status] Needs Review This PR is ready for review. label Mar 13, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2020

Howdy! The Jetpack team has disappeared for a few days to a secret island lair to concoct new ways to make Jetpack one hundred billion percent better. As a result, your Pull Request may not be reviewed right away. Do not worry, we will be back next week to look at your work! Thank you for your understanding.

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Mar 13, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 7016982

zinigor
zinigor approved these changes Mar 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran Ads using this PR, everything seems to work fine. I don't know how to test the functionality of the actual script, but it seems to be copied correctly because it parses well with no console errors.

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 17, 2020
jeherve
jeherve approved these changes Mar 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me. Merging.

@jeherve jeherve merged commit 2cb69bb into master Mar 26, 2020
@jeherve jeherve deleted the update/wordads-ipw-loader branch March 26, 2020 08:00
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 26, 2020
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
Changelog: add #14990
85dca6d
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

+1 more reviewer

@zinigor zinigor zinigor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dbspringer dbspringer

Labels

[Feature] WordAds [Type] Janitorial

Projects

None yet

Milestone

8.4

Development

Successfully merging this pull request may close these issues.

5 participants

@dbspringer @jetpackbot @zinigor @jeherve @matticbot