Comment Likes: Remove the dependency on Noticons#14784
Merged
Conversation
Currently the Noticons font is loaded solely for the purpose of displaying the "like" star from the Noticons icon set. This adds 20 kB to the total page load size when only comment likes are enabled. This commit replaces the icon character by an inline SVG used on WPCOM.
0b1573f to
d5ef47c
Compare
Collaborator
This is an automated check which relies on |
kraftbj
approved these changes
Mar 2, 2020
Contributor
|
Caution: This PR has changes that must be merged to WordPress.com |
jeherve
added a commit
that referenced
this pull request
Mar 31, 2020
* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Noticons font is loaded solely for the purpose
of displaying the "like" star from the Noticons icon set. This
adds 20 kB to the total page load size when only comment likes
are enabled.
This commit replaces the icon character by an inline SVG used
on WPCOM.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
likesmodule and affects comment like buttons.Testing instructions:
Noticonsfont is not being loaded.Proposed changelog entry
Concern
I recognize that hardcoding the inline image value into the stylesheet is not a great solution. Is there a tool in the build pipeline that would be able to automate the task, i.e. fetch the glyph from Noticons and inline it in the generated CSS?