Skip to content

CSS Tidy: Add mask, scroll, and object-fit properties#15044

Merged
jeherve merged 2 commits intomasterfrom
update/#14993
Mar 20, 2020
Merged

CSS Tidy: Add mask, scroll, and object-fit properties#15044
jeherve merged 2 commits intomasterfrom
update/#14993

Conversation

@nielslange
Copy link
Copy Markdown
Contributor

@nielslange nielslange commented Mar 19, 2020 •
edited by lancewillett
Loading

Fixes #14993

Changes proposed in this Pull Request:

Add mask, scroll, and object-fit properties to CSS support.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

It's an enhancement of the current supported CSS elements.

Testing instructions:

Proposed changelog entry for your changes:

  • Add support for more CSS 3.0 properties: mask , scroll, and object-fit

@nielslange nielslange requested a review from a team March 19, 2020 00:43
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Mar 19, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello nielslange! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40527-code before merging this PR. Thank you!

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Mar 19, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 9588c1a

@nielslange nielslange added the [Status] Needs Review This PR is ready for review. label Mar 19, 2020
@jeherve jeherve added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Custom CSS labels Mar 19, 2020
@jeherve jeherve requested a review from lancewillett March 19, 2020 11:32
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Mar 19, 2020

@lancewillett Adding you as a reviewer since you've worked on this recently.

Thank you!

@jeherve jeherve added this to the 8.4 milestone Mar 19, 2020
@lancewillett
Copy link
Copy Markdown
Contributor

lancewillett commented Mar 19, 2020

Even though my HACK week developer time is now over, I'll try to look soon. Should be a quick one.

lancewillett
lancewillett requested changes Mar 20, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lancewillett lancewillett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nielslange Could you please also add object-fit and object-position?

@lancewillett
Copy link
Copy Markdown
Contributor

lancewillett commented Mar 20, 2020

@jeherve Does it mess up the sync if I change Phabricator diff summary text?

@nielslange
Copy link
Copy Markdown
Contributor Author

nielslange commented Mar 20, 2020

@lancewillett In 3f2897e you can find the updated version as requested by you in #15044 (review)

@jeherve
Copy link
Copy Markdown
Member

jeherve commented Mar 20, 2020 •
edited
Loading

Does it mess up the sync if I change Phabricator diff summary text?

It doesn't, no worries! However, if you make changes to the diff itself, those changes will be lost every time the bot updates the diff because the PR here has been updated.

lancewillett
lancewillett previously approved these changes Mar 20, 2020
View reviewed changes
@lancewillett lancewillett changed the title CSS Tidy: Add mask and scroll properties CSS Tidy: Add mask, scroll, and object-fit properties Mar 20, 2020
jeherve
jeherve approved these changes Mar 20, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, should be good to merge once the tests pass (I had to rebase to fix a bad test).

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 20, 2020
@lancewillett
Copy link
Copy Markdown
Contributor

lancewillett commented Mar 20, 2020

WP.com change landed in r204590-wpcom

@lancewillett
Copy link
Copy Markdown
Contributor

lancewillett commented Mar 20, 2020

I love that GitHub to Phabricator push. Wow! That is a time saver.

@jeherve jeherve merged commit d9feaf4 into master Mar 20, 2020
@jeherve jeherve deleted the update/#14993 branch March 20, 2020 18:43
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 20, 2020
jeherve added a commit that referenced this pull request Mar 23, 2020
@jeherve
Changelog: add #15044
1850902
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
@jeherve jeherve mentioned this pull request Sep 9, 2020
Closed
@ryelle ryelle mentioned this pull request Mar 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

@lancewillett lancewillett lancewillett left review comments

Assignees

@nielslange nielslange

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Custom CSS Touches WP.com Files

Projects

None yet

Milestone

8.4

Development

Successfully merging this pull request may close these issues.

CSS Tidy: improve modern CSS support for properties such as mask and scroll

5 participants

@nielslange @matticbot @jetpackbot @jeherve @lancewillett