Skip to content

Social Menu & Icon: Add Ravelry Icon#15065

Merged
jeherve merged 4 commits intoAutomattic:masterfrom
Aurorum:add/ravelry-icon
Mar 24, 2020
Merged

Social Menu & Icon: Add Ravelry Icon#15065
jeherve merged 4 commits intoAutomattic:masterfrom
Aurorum:add/ravelry-icon

Conversation

@Aurorum
Copy link
Copy Markdown
Contributor

@Aurorum Aurorum commented Mar 20, 2020

Fixes an issue raised in p8HJWS-ui-p2

Changes proposed in this Pull Request:

  • Adds support for Ravelry to the Social Menu and widget. According to the original discussion, it has surpassed 9 million users.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Adds to an existing feature

Testing instructions:

Go to the Customizer with a theme that supports social menus and add a social menu using the link ravelry.com, and do the same with the Social Icons widget, then verify the icon displays as expected.

Screenshot 2020-03-20 at 12 02 25

Proposed changelog entry for your changes:

  • Social Menus: Add Ravelry support

@Aurorum Aurorum requested a review from a team March 20, 2020 12:19
@jetpackbot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against ec0195d

@jeherve jeherve added [Feature] Theme Tools [Status] Needs Review This PR is ready for review. [Status] Needs Design Review Design has been added. Needs a review! Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Mar 24, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 24, 2020
Copy link
Copy Markdown
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise looks good to me!

@keoshi keoshi added [Status] Design Review Complete and removed [Status] Needs Design Review Design has been added. Needs a review! labels Mar 24, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 24, 2020
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me as well. Merging. Thank you!

@jeherve jeherve merged commit 63fee0f into Automattic:master Mar 24, 2020
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 24, 2020
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Mar 24, 2020

r204698-wpcom

jeherve added a commit that referenced this pull request Mar 31, 2020
jeherve added a commit that referenced this pull request Mar 31, 2020
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Extra Sidebar Widgets [Feature] Theme Tools Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants