Skip to content

Update default zoom for multi-point maps#15126

Merged
jeherve merged 1 commit intomasterfrom
update/map-block-autozoom
Mar 26, 2020
Merged

Update default zoom for multi-point maps#15126
jeherve merged 1 commit intomasterfrom
update/map-block-autozoom

Conversation

@rclachance
Copy link
Copy Markdown
Contributor

@rclachance rclachance commented Mar 25, 2020 •
edited
Loading

While using the map block with multiple points, the zoom fit feels really tight.

This PR would increase the padding around the points, giving users more context to what's immediately surrounding their points.

Before

Screen Shot 2020-03-25 at 6 18 35 PM

After

Screen Shot 2020-03-25 at 6 18 54 PM

Testing Instructions

  • Insert a map block on a page with 2 or more points.
  • Check the padding around these points.

Proposed changelog entry for your changes:

  • Slightly decreases the automatic zoom on multi-point map blocks.

@rclachance rclachance added [Status] Needs Review This PR is ready for review. [Block] Map labels Mar 25, 2020
@rclachance rclachance requested review from a team and kraftbj March 25, 2020 22:34
@rclachance rclachance self-assigned this Mar 25, 2020
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Mar 25, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello rclations! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40863-code before merging this PR. Thank you!

@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Mar 25, 2020

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against f4f7783

@jeherve jeherve added the Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Mar 26, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 26, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 26, 2020
jeherve
jeherve approved these changes Mar 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nicer, nice improvement! Merging.

@jeherve jeherve merged commit de626ad into master Mar 26, 2020
@jeherve jeherve deleted the update/map-block-autozoom branch March 26, 2020 16:26
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 26, 2020
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Mar 26, 2020

r204892-wpcom

jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
Changelog: add #15126
32a8ada
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve approved these changes

@kraftbj kraftbj Awaiting requested review from kraftbj

Assignees

@rclachance rclachance

Labels

[Block] Map Enhancement Changes to an existing feature — removing, adding, or changing parts of it Touches WP.com Files

Projects

None yet

Milestone

8.4

Development

Successfully merging this pull request may close these issues.

4 participants

@rclachance @matticbot @jetpackbot @jeherve