chore(arduino): merge changes at #105 for Arduino.#106
Merged
faustbrian merged 31 commits intoArkEcosystemArchive:arduinofrom Jul 2, 2019
sleepdefic1t:chore(arduino)/merge-changes-at-105
Merged
chore(arduino): merge changes at #105 for Arduino.#106faustbrian merged 31 commits intoArkEcosystemArchive:arduinofrom sleepdefic1t:chore(arduino)/merge-changes-at-105
faustbrian merged 31 commits intoArkEcosystemArchive:arduinofrom
sleepdefic1t:chore(arduino)/merge-changes-at-105
Conversation
Windows doesn't handle dynamic allocation well. - transaction.cpp - explicitly define est. doc max size of 900. - No need for string since we're stating size. - message.cpp - let string handle doc size allocation.
AUnit has stopped correctly building tests for the partially-supported ESP8266 platform. It seems this may be a change in ESP8266 Core, so this PR disables ESP8266 tests in PlatformIO until support is worked out.
- Further decouple OS code from IoT code. - Add missing ESP8266 functionality. - Allow removal of lib/STL dependency. - STL lib is only included to provide a conv. method for IoT to use date.h - date.h is now only used by OS builds, which will have the STL by default. - update changelog. - add PIO filters for lib/date.
The Arduino IDE requires the use of a single true tab separator between the keyword name and identifier. When spaces are used rather than a true tab, the keyword is not highlighted. Reference: https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification#keywords
Current tests are ran in different orders per platform. This led to a modified global test custom_network being modified improperly. This PR properly handles that order variation by creating a local object to be modified. In future iterations, an AbstractNetwork will allow `const`.
Current implementation sometimes fails to properly serialize numbers in the `toJson()` method. This is especially detrimental to some Linux builds and all Arduino IDE builds (Arduino IDE Library version (Cpp-Crypto-Arduino-v.0.3.0)). Specifically, this PR does the following: - moves `<cinttypes>` to `crypto_helpers.h` for non-IoT builds. - forces type serialization for: - `amount` (llu/uint64_t). - `fee` (llu/uint64_t). - `network` (uint8_t/int). - `timestamp` (lu/uint32_t). - `type` (uint8_t/int). - `version` (uint8_t/int). - updates the changelog.
The current implementation only allows use with Devnet unless values are manually changed in `/src`. This PR enables network configuration via the public api. (Devnet, Mainnet, Testnet, and Custom Networks (bridgechains). Specifically this PR does the following: - Creates a Configuration class. - Creates Fee and Network Manager children for the Configuration class. - Allows passing a `Configuration to` Transaction Builder with a default value of `Devnet` & `StaticFees` (non-breaking). - Adds a FeePolicy-type. - Adds a Fee class (container for fee policies). - Adds a Networks class (container for preset networks). - Updates the TransactionTypes enum. - Improves the `Network` class and Network implementions. - Updates the `Slot` class to reflect changes (non-breaking). - Updates Transaction-related classes to reflect updates (non-breaking). - Adds tests for all changes. - Updates the Arduino IDE script. - Updates `.ino` Arduino sketches with Configuration examples. - Updates documentation with Configuration examples. - Updates the `keywords.txt` file to reflect changes. - Updates the changelog. - Updates version to `v.0.6.0`. Some small changes are technically breaking-changes. (e.g. `Devnet` vs `Devnet()`, and `Fees` vs `Fees::StaticFeePolicy`)
|
The ci/circleci: build-arduino-default job is failing as of 79d105708aa34d7cca186bcad41b6221cad1f266. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
|
The ci/circleci: build-arduino-default job is failing as of 3ea91efa20543666e6258d4f89a83cf4d95eb46c. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
…e(arduino)/merge-changes-at-105
…ge-changes-at-105
faustbrian
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR merges all changes from #105 for release on the Arduino branch.
Specifically this PR does the following:
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
There are two breaking changes in this PR.
(e.g. Devnet vs Devnet(), and Fees vs Fees::StaticFeePolicy)
The PR fulfills these requirements:
developbranch, not themasterbranch