fix: Update Build Flag#69
Merged
faustbrian merged 20 commits intoArkEcosystemArchive:masterfrom Feb 19, 2019
sleepdefic1t:fix/update-build-flag
Merged
fix: Update Build Flag#69faustbrian merged 20 commits intoArkEcosystemArchive:masterfrom sleepdefic1t:fix/update-build-flag
faustbrian merged 20 commits intoArkEcosystemArchive:masterfrom
sleepdefic1t:fix/update-build-flag
Conversation
misc: merge from upstream
- list ArduinoJson as a dependency. - add Arduino sketch path to config. - fix the 'platformio_example' path.
This reverts commit 55d830b.
- only affects PIO builds where Cpp-Crypto is an external dependency.
|
@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 87.82% 87.82%
=======================================
Files 29 29
Lines 805 805
=======================================
Hits 707 707
Misses 98 98Continue to review full report at Codecov.
|
faustbrian
approved these changes
Feb 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
PlatformIO projects--where Cpp-Crypto is an external dependency--will not find find this directory and will fail to build.
This PR adds
src/libto the build flags inlibrary.jsonand resolves this issue.Types of changes
Checklist