test(networks): Fix AbstractNetwork Tests#102
Merged
faustbrian merged 2 commits intoArkEcosystemArchive:developfrom Jun 21, 2019
sleepdefic1t:test(networks)/fix-abstractnetwork
Merged
test(networks): Fix AbstractNetwork Tests#102faustbrian merged 2 commits intoArkEcosystemArchive:developfrom sleepdefic1t:test(networks)/fix-abstractnetwork
faustbrian merged 2 commits intoArkEcosystemArchive:developfrom
sleepdefic1t:test(networks)/fix-abstractnetwork
Conversation
Current tests are ran in different orders per platform. This led to a modified global test custom_network being modified improperly. This PR properly handles that order variation by creating a local object to be modified. In future iterations, an AbstractNetwork will allow `const`.
|
The ci/circleci: build-linux-default job is failing as of 2f1951b200c8a5fa7e8016229592521a0a70bb76. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
1 similar comment
|
The ci/circleci: build-linux-default job is failing as of 2f1951b200c8a5fa7e8016229592521a0a70bb76. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
faustbrian
approved these changes
Jun 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current tests are ran in different orders per platform.
This led to a global test custom_network (AbstractNetwork) being modified incorrectly.
This PR properly handles that order variation by creating a local object to be modified instead.
Tests may fail until #101 is merged and this PR is rebased.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranch